From: Christian Ruppert <christian.ruppert@abilis.com>
To: Axel Lin <axel.lin@ingics.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Kumar Gala <galak@codeaurora.org>,
Sascha Leuenberger <sascha.leuenberger@abilis.com>,
linux-gpio@vger.kernel.org
Subject: Re: [PATCH] gpio: tb10x: Set output value before setting direction to output
Date: Thu, 31 Oct 2013 13:42:06 +0100 [thread overview]
Message-ID: <20131031124206.GC7093@ab42.lan> (raw)
In-Reply-To: <1383189826.21285.0.camel@phoenix>
On Thu, Oct 31, 2013 at 11:23:46AM +0800, Axel Lin wrote:
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Christian Ruppert <christian.ruppert@abilis.com>
> ---
> drivers/gpio/gpio-tb10x.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpio/gpio-tb10x.c b/drivers/gpio/gpio-tb10x.c
> index a0391bc..9116cdf 100644
> --- a/drivers/gpio/gpio-tb10x.c
> +++ b/drivers/gpio/gpio-tb10x.c
> @@ -132,6 +132,7 @@ static int tb10x_gpio_direction_out(struct gpio_chip *chip,
> int mask = BIT(offset);
> int val = TB10X_GPIO_DIR_OUT << offset;
>
> + tb10x_gpio_set(chip, offset, value);
> tb10x_set_bits(tb10x_gpio, OFFSET_TO_REG_DDR, mask, val);
>
> return 0;
> --
> 1.8.1.2
>
>
>
next prev parent reply other threads:[~2013-10-31 13:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-31 3:23 [PATCH] gpio: tb10x: Set output value before setting direction to output Axel Lin
2013-10-31 12:42 ` Christian Ruppert [this message]
2013-11-12 19:38 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131031124206.GC7093@ab42.lan \
--to=christian.ruppert@abilis.com \
--cc=axel.lin@ingics.com \
--cc=galak@codeaurora.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=sascha.leuenberger@abilis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).