* [PATCH] gpio: tb10x: Set output value before setting direction to output
@ 2013-10-31 3:23 Axel Lin
2013-10-31 12:42 ` Christian Ruppert
2013-11-12 19:38 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Axel Lin @ 2013-10-31 3:23 UTC (permalink / raw)
To: Linus Walleij
Cc: Christian Ruppert, Kumar Gala, Sascha Leuenberger, linux-gpio
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/gpio/gpio-tb10x.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpio/gpio-tb10x.c b/drivers/gpio/gpio-tb10x.c
index a0391bc..9116cdf 100644
--- a/drivers/gpio/gpio-tb10x.c
+++ b/drivers/gpio/gpio-tb10x.c
@@ -132,6 +132,7 @@ static int tb10x_gpio_direction_out(struct gpio_chip *chip,
int mask = BIT(offset);
int val = TB10X_GPIO_DIR_OUT << offset;
+ tb10x_gpio_set(chip, offset, value);
tb10x_set_bits(tb10x_gpio, OFFSET_TO_REG_DDR, mask, val);
return 0;
--
1.8.1.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] gpio: tb10x: Set output value before setting direction to output
2013-10-31 3:23 [PATCH] gpio: tb10x: Set output value before setting direction to output Axel Lin
@ 2013-10-31 12:42 ` Christian Ruppert
2013-11-12 19:38 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Christian Ruppert @ 2013-10-31 12:42 UTC (permalink / raw)
To: Axel Lin; +Cc: Linus Walleij, Kumar Gala, Sascha Leuenberger, linux-gpio
On Thu, Oct 31, 2013 at 11:23:46AM +0800, Axel Lin wrote:
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Christian Ruppert <christian.ruppert@abilis.com>
> ---
> drivers/gpio/gpio-tb10x.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpio/gpio-tb10x.c b/drivers/gpio/gpio-tb10x.c
> index a0391bc..9116cdf 100644
> --- a/drivers/gpio/gpio-tb10x.c
> +++ b/drivers/gpio/gpio-tb10x.c
> @@ -132,6 +132,7 @@ static int tb10x_gpio_direction_out(struct gpio_chip *chip,
> int mask = BIT(offset);
> int val = TB10X_GPIO_DIR_OUT << offset;
>
> + tb10x_gpio_set(chip, offset, value);
> tb10x_set_bits(tb10x_gpio, OFFSET_TO_REG_DDR, mask, val);
>
> return 0;
> --
> 1.8.1.2
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gpio: tb10x: Set output value before setting direction to output
2013-10-31 3:23 [PATCH] gpio: tb10x: Set output value before setting direction to output Axel Lin
2013-10-31 12:42 ` Christian Ruppert
@ 2013-11-12 19:38 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2013-11-12 19:38 UTC (permalink / raw)
To: Axel Lin
Cc: Christian Ruppert, Kumar Gala, Sascha Leuenberger,
linux-gpio@vger.kernel.org
On Thu, Oct 31, 2013 at 4:23 AM, Axel Lin <axel.lin@ingics.com> wrote:
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Patch applied for fixes with Christian's ACK.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-11-12 19:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-31 3:23 [PATCH] gpio: tb10x: Set output value before setting direction to output Axel Lin
2013-10-31 12:42 ` Christian Ruppert
2013-11-12 19:38 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).