From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [RFC 01/23] gpio/omap: raw read and write endian fix Date: Tue, 19 Nov 2013 07:43:53 -0800 Message-ID: <20131119154353.GC10317@atomide.com> References: <1384560086-11994-1-git-send-email-taras.kondratiuk@linaro.org> <1384560086-11994-2-git-send-email-taras.kondratiuk@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-03-ewr.mailhop.org ([204.13.248.66]:52316 "EHLO mho-01-ewr.mailhop.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751307Ab3KSPn7 (ORCPT ); Tue, 19 Nov 2013 10:43:59 -0500 Content-Disposition: inline In-Reply-To: Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Linus Walleij Cc: Taras Kondratiuk , Javier Martinez Canillas , Linux-OMAP , linaro-networking@linaro.org, Victor Kamensky , Santosh Shilimkar , Kevin Hilman , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" * Linus Walleij [131119 01:29]: > On Sat, Nov 16, 2013 at 1:01 AM, Taras Kondratiuk > wrote: > > > From: Victor Kamensky > > > > All OMAP IP blocks expect LE data, but CPU may operate in BE mode. > > Need to use endian neutral functions to read/write h/w registers. > > I.e instead of __raw_read[lw] and __raw_write[lw] functions code > > need to use read[lw]_relaxed and write[lw]_relaxed functions. > > If the first simply reads/writes register, the second will byteswap > > it if host operates in BE mode. > > > > Changes are trivial sed like replacement of __raw_xxx functions > > with xxx_relaxed variant. > > > > Signed-off-by: Victor Kamensky > > Signed-off-by: Taras Kondratiuk > > Since I generally just dislike __raw accessors I went and applied > this. If it collides with any of Tony's fixup work I might need to > take the patch out again, no big deal. Thanks, this should not conflict with what I have. I just had few fixes for the twl4030-gpio for older omaps and I doubt that I have further driver dependencies beyond that for my clean-up work. > Some ACKs would be nice, but unless there are major objections > this stays merged. Acked-by: Tony Lindgren