From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
linux-acpi@vger.kernel.org,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Linus Walleij <linus.walleij@linaro.org>,
Chris Ball <cjb@laptop.org>,
Johannes Berg <johannes@sipsolutions.net>,
Rhyland Klein <rklein@nvidia.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Alexandre Courbot <acourbot@nvidia.com>,
Mathias Nyman <mathias.nyman@linux.intel.com>,
Rob Landley <rob@landley.net>,
linux-gpio@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/5] net: rfkill: gpio: convert to descriptor-based GPIO interface
Date: Fri, 22 Nov 2013 12:50:16 +0200 [thread overview]
Message-ID: <20131122105016.GA8670@xps8300> (raw)
In-Reply-To: <CAHp75VeEEWCVXz4X1qazfVKZBDBgP6NPfPnuS-b7qEiT4m7f=g@mail.gmail.com>
Hi Andy,
On Thu, Nov 21, 2013 at 05:32:28PM +0200, Andy Shevchenko wrote:
> > + /* Make sure at-least one of the GPIO is defined and that
> > + * a name is specified for this instance
> > + */
> > + if ((!rfkill->reset_gpio && !rfkill->shutdown_gpio) || !rfkill->name) {
> > + pr_warn("%s: invalid platform data\n", __func__);
> > + return -EINVAL;
> > + }
> > +
> > + if (pdata && pdata->gpio_runtime_setup) {
> > + ret = pdata->gpio_runtime_setup(pdev);
> > if (ret) {
> > - pr_warn("%s: failed to get shutdown gpio.\n", __func__);
> > + pr_warn("%s: can't set up gpio\n", __func__);
>
> Could you use dev_* family of functions to print messages?
OK, I'll change them. Thanks!
--
heikki
next prev parent reply other threads:[~2013-11-22 10:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-21 14:45 [PATCH 0/5] gpio / ACPI: convert users to gpiod_* and drop acpi_gpio.h Mika Westerberg
2013-11-21 14:45 ` [PATCH 1/5] net: rfkill: gpio: convert to descriptor-based GPIO interface Mika Westerberg
2013-11-21 15:24 ` Heikki Krogerus
2013-11-21 17:05 ` Rhyland Klein
2013-11-21 17:22 ` Mika Westerberg
2013-11-21 21:46 ` Rafael J. Wysocki
2013-11-21 15:32 ` Andy Shevchenko
2013-11-22 10:50 ` Heikki Krogerus [this message]
2013-11-21 14:45 ` [PATCH 2/5] mmc: sdhci-acpi: covert to use GPIO descriptor API Mika Westerberg
2013-11-22 8:53 ` Adrian Hunter
2013-11-22 10:18 ` Mika Westerberg
2013-11-21 14:45 ` [PATCH 3/5] gpio / ACPI: register to ACPI events automatically Mika Westerberg
2013-11-21 14:45 ` [PATCH 4/5] gpio / ACPI: get rid of acpi_gpio.h Mika Westerberg
2013-11-21 14:45 ` [PATCH 5/5] Documentation / ACPI: update to GPIO descriptor API Mika Westerberg
2013-11-21 15:01 ` [PATCH 0/5] gpio / ACPI: convert users to gpiod_* and drop acpi_gpio.h Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131122105016.GA8670@xps8300 \
--to=heikki.krogerus@linux.intel.com \
--cc=acourbot@nvidia.com \
--cc=adrian.hunter@intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=cjb@laptop.org \
--cc=johannes@sipsolutions.net \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathias.nyman@linux.intel.com \
--cc=mika.westerberg@linux.intel.com \
--cc=rjw@rjwysocki.net \
--cc=rklein@nvidia.com \
--cc=rob@landley.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).