From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Alexandre Courbot <gnurou@gmail.com>
Cc: Alexandre Courbot <acourbot@nvidia.com>,
Linus Walleij <linus.walleij@linaro.org>,
Stephen Warren <swarren@wwwdotorg.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] gpiolib: add missing declarations
Date: Mon, 25 Nov 2013 11:28:02 +0200 [thread overview]
Message-ID: <20131125092802.GQ2281@intel.com> (raw)
In-Reply-To: <CAAVeFu+wFAqroiyzwRQLkRAmhVQV-efOYA51DTHUwMMA1nTYxA@mail.gmail.com>
On Mon, Nov 25, 2013 at 06:07:10PM +0900, Alexandre Courbot wrote:
> On Mon, Nov 25, 2013 at 5:58 PM, Mika Westerberg
> <mika.westerberg@linux.intel.com> wrote:
> > On Sat, Nov 23, 2013 at 02:54:29PM +0900, Alexandre Courbot wrote:
> >> Add missing declarations and include files to avoid warnings during
> >> compilation of include/gpio/driver.h.
> >
> > It would be good to have those warnings included in the changelog as well.
>
> As in, copy-pasting the compiler's output? Isn't the change explicit enough?
If you just do 'git log' you can't see the change itself and that's where
the changelog should help. If I see some warnings when I build the kernel,
the first thing I usually do is to check 'git log' against linux-next and
see if someone has already fixed that warning (grepping the warning message
from changelog).
next prev parent reply other threads:[~2013-11-25 9:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-23 5:54 [PATCH] gpiolib: add missing declarations Alexandre Courbot
2013-11-25 8:58 ` Mika Westerberg
2013-11-25 9:07 ` Alexandre Courbot
2013-11-25 9:28 ` Mika Westerberg [this message]
2013-11-25 9:26 ` Alex Courbot
2013-11-25 9:34 ` [PATCH v2] " Alexandre Courbot
2013-11-28 14:32 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131125092802.GQ2281@intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=acourbot@nvidia.com \
--cc=gnurou@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).