From: Baruch Siach <baruch@tkos.co.il>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-gpio@vger.kernel.org,
Alexandre Courbot <acourbot@nvidia.com>,
Haojian Zhuang <haojian.zhuang@linaro.org>,
Deepak Sikri <deepak.sikri@st.com>
Subject: Re: [PATCH 3/3] gpio: pl061: remove confusing naming
Date: Wed, 27 Nov 2013 06:19:04 +0200 [thread overview]
Message-ID: <20131127041904.GU32436@tarshish> (raw)
In-Reply-To: <1385472248-26039-1-git-send-email-linus.walleij@linaro.org>
Hi Linus,
On Tue, Nov 26, 2013 at 02:24:08PM +0100, Linus Walleij wrote:
> Drop the " gpio" suffix after the pl061 irq_chip name:
> this is only confusing: an irqchip name should be a single,
> short, simple string that looks nice in /proc/interrupts.
>
> Drop the nameing of each individual IRQ to "pl061" - I
> think this naming function is for naming the IRQ line,
> not for boilerplating them all with the name of the
> parent controller, which is already known from the
> .name field of the irq_chip.
>
> Cc: Haojian Zhuang <haojian.zhuang@linaro.org>
> Cc: Baruch Siach <baruch@tkos.co.il>
> Cc: Deepak Sikri <deepak.sikri@st.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Acked-by: Baruch Siach <baruch@tkos.co.il>
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
prev parent reply other threads:[~2013-11-27 4:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-26 13:24 [PATCH 3/3] gpio: pl061: remove confusing naming Linus Walleij
2013-11-27 4:19 ` Baruch Siach [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131127041904.GU32436@tarshish \
--to=baruch@tkos.co.il \
--cc=acourbot@nvidia.com \
--cc=deepak.sikri@st.com \
--cc=haojian.zhuang@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox