Re: [PATCH] gpiolib: don't bother warning when failing to get gpios

[Heikki Krogerus <heikki.krogerus@linux.intel.com>]

Hi,

On Fri, Nov 29, 2013 at 06:37:35PM +0900, Alexandre Courbot wrote:
> On Fri, Nov 29, 2013 at 6:16 PM, Heikki Krogerus
> > diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
> > index 4e10b10..2f0305e 100644
> > --- a/drivers/gpio/gpiolib.c
> > +++ b/drivers/gpio/gpiolib.c
> > @@ -2434,10 +2434,8 @@ struct gpio_desc *__must_check gpiod_get_index(struct device *dev,
> >                 desc = gpiod_find(dev, con_id, idx, &flags);
> >         }
> >
> > -       if (IS_ERR(desc)) {
> > -               dev_warn(dev, "lookup for GPIO %s failed\n", con_id);
> > +       if (IS_ERR(desc))
> >                 return desc;
> > -       }
> >
> >         status = gpiod_request(desc, con_id);
> 
> I kind of agree with the logic that motivates this patch, but how
> about turning this warning into dev_dbg() instead so that people who
> wish so can still continue using it?

Sure, I'll send v2 of this and do just that.

Thanks,

-- 
heikki