From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Jean Delvare <jdelvare@suse.de>,
Mathias Nyman <mathias.nyman@linux.intel.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH v2] gpio-lynxpoint: Allow building as a module
Date: Fri, 29 Nov 2013 13:13:53 +0200 [thread overview]
Message-ID: <20131129111353.GG2281@intel.com> (raw)
In-Reply-To: <CACRpkdZYxsEn=YHG9jLnggEXKoskfvijHYe2-=i2fxf23Q2N3w@mail.gmail.com>
On Fri, Nov 29, 2013 at 11:27:23AM +0100, Linus Walleij wrote:
> On Wed, Nov 27, 2013 at 3:46 PM, Jean Delvare <jdelvare@suse.de> wrote:
>
> > Change CONFIG_GPIO_LYNXPOINT from bool to tristate so that the
> > gpio-lynxpoint driver can be built as a module.
> >
> > Add the required glue: an exit function to unregister the driver, and
> > module information.
> >
> > Signed-off-by: Jean Delvare <jdelvare@suse.de>
> > Cc: Mathias Nyman <mathias.nyman@linux.intel.com>
> > Cc: Linus Walleij <linus.walleij@linaro.org>
>
> Hm I think Mika is working on this driver now, Mika can you have
> a look at this patch?
I don't have any objections in merging this patch. It looks good and I
can't remember any reasons why it can't be compiled as a module :)
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
next prev parent reply other threads:[~2013-11-29 11:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-27 14:46 [PATCH v2] gpio-lynxpoint: Allow building as a module Jean Delvare
2013-11-29 10:27 ` Linus Walleij
2013-11-29 11:13 ` Mika Westerberg [this message]
2013-11-29 12:40 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131129111353.GG2281@intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=jdelvare@suse.de \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=mathias.nyman@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).