[PATCH v2] gpio-lynxpoint: Allow building as a module

[PATCH v2] gpio-lynxpoint: Allow building as a module

[Jean Delvare]

Change CONFIG_GPIO_LYNXPOINT from bool to tristate so that the
gpio-lynxpoint driver can be built as a module.

Add the required glue: an exit function to unregister the driver, and
module information.

Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: Mathias Nyman <mathias.nyman@linux.intel.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
---
 drivers/gpio/Kconfig          |    2 +-
 drivers/gpio/gpio-lynxpoint.c |   11 +++++++++++
 2 files changed, 12 insertions(+), 1 deletion(-)

--- linux-3.13-rc1.orig/drivers/gpio/Kconfig	2013-11-27 14:27:39.776405958 +0100
+++ linux-3.13-rc1/drivers/gpio/Kconfig	2013-11-27 14:47:01.604049477 +0100
@@ -353,7 +353,7 @@ config GPIO_GE_FPGA
 	  board computers.
 
 config GPIO_LYNXPOINT
-	bool "Intel Lynxpoint GPIO support"
+	tristate "Intel Lynxpoint GPIO support"
 	depends on ACPI && X86
 	select IRQ_DOMAIN
 	help
--- linux-3.13-rc1.orig/drivers/gpio/gpio-lynxpoint.c	2013-11-26 15:44:46.827657836 +0100
+++ linux-3.13-rc1/drivers/gpio/gpio-lynxpoint.c	2013-11-27 15:42:16.563778124 +0100
@@ -469,4 +469,15 @@ static int __init lp_gpio_init(void)
 	return platform_driver_register(&lp_gpio_driver);
 }
 
+static void __exit lp_gpio_exit(void)
+{
+	platform_driver_unregister(&lp_gpio_driver);
+}
+
 subsys_initcall(lp_gpio_init);
+module_exit(lp_gpio_exit);
+
+MODULE_AUTHOR("Mathias Nyman (Intel)");
+MODULE_DESCRIPTION("GPIO interface for Intel Lynxpoint");
+MODULE_LICENSE("GPL");
+MODULE_ALIAS("platform:lp_gpio");


-- 
Jean Delvare
Suse L3 Support

Re: [PATCH v2] gpio-lynxpoint: Allow building as a module

[Linus Walleij]

On Wed, Nov 27, 2013 at 3:46 PM, Jean Delvare <jdelvare@suse.de> wrote:

> Change CONFIG_GPIO_LYNXPOINT from bool to tristate so that the
> gpio-lynxpoint driver can be built as a module.
>
> Add the required glue: an exit function to unregister the driver, and
> module information.
>
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Cc: Mathias Nyman <mathias.nyman@linux.intel.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>

Hm I think Mika is working on this driver now, Mika can you have
a look at this patch?

Yours,
Linus Walleij

Re: [PATCH v2] gpio-lynxpoint: Allow building as a module

[Mika Westerberg]

On Fri, Nov 29, 2013 at 11:27:23AM +0100, Linus Walleij wrote:
> On Wed, Nov 27, 2013 at 3:46 PM, Jean Delvare <jdelvare@suse.de> wrote:
> 
> > Change CONFIG_GPIO_LYNXPOINT from bool to tristate so that the
> > gpio-lynxpoint driver can be built as a module.
> >
> > Add the required glue: an exit function to unregister the driver, and
> > module information.
> >
> > Signed-off-by: Jean Delvare <jdelvare@suse.de>
> > Cc: Mathias Nyman <mathias.nyman@linux.intel.com>
> > Cc: Linus Walleij <linus.walleij@linaro.org>
> 
> Hm I think Mika is working on this driver now, Mika can you have
> a look at this patch?

I don't have any objections in merging this patch. It looks good and I
can't remember any reasons why it can't be compiled as a module :)

Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>

Re: [PATCH v2] gpio-lynxpoint: Allow building as a module

[Linus Walleij]

On Wed, Nov 27, 2013 at 3:46 PM, Jean Delvare <jdelvare@suse.de> wrote:

> Change CONFIG_GPIO_LYNXPOINT from bool to tristate so that the
> gpio-lynxpoint driver can be built as a module.
>
> Add the required glue: an exit function to unregister the driver, and
> module information.
>
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Cc: Mathias Nyman <mathias.nyman@linux.intel.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>

Patch applied with Mika's ACK.

Yours,
Linus Walleij