From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jamie Iles Subject: Re: [PATCH v8] gpio: add a driver for the Synopsys DesignWare APB GPIO block Date: Thu, 5 Dec 2013 16:54:39 +0000 Message-ID: <20131205165439.GB5924@maple> References: <1386088876-29205-1-git-send-email-delicious.quinoa@gmail.com> <1386088876-29205-2-git-send-email-delicious.quinoa@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1386088876-29205-2-git-send-email-delicious.quinoa-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Alan Tull Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Linus Walleij , linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Jamie Iles , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Grant Likely , Rob Herring , Steffen Trumtrar , Sebastian Hesselbarth , Heiko Stuebner , Alan Tull , Dinh Nguyen , Yves Vandervennet List-Id: linux-gpio@vger.kernel.org Hi Alan, One minor comment below, otherwise looks great! Signed-off-by: Jamie Iles Thanks, Jamie On Tue, Dec 03, 2013 at 10:41:16AM -0600, Alan Tull wrote: > diff --git a/drivers/gpio/gpio-dwapb.c b/drivers/gpio/gpio-dwapb.c > new file mode 100644 > index 0000000..e6dc61f > --- /dev/null > +++ b/drivers/gpio/gpio-dwapb.c ... > +static unsigned int dwapb_gpio_nr_ports(struct device_node *of_node) > +{ > + unsigned int nr_ports = 0; > + struct device_node *np; > + > + for_each_child_of_node(of_node, np) > + ++nr_ports; > + > + return nr_ports; > +} I notice that we now have of_get_child_count() which didn't exist when I first wrote the driver, we could use that now. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html