From: "Heiko Stübner" <heiko@sntech.de>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: "José Miguel Gonçalves" <jose.goncalves@inov.pt>,
"Ben Dooks" <ben-linux@fluff.org>,
"Kukjin Kim" <kgene.kim@samsung.com>,
"Tomasz Figa" <t.figa@samsung.com>,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ARM: S3C24XX: Fix configuration of gpio port sizes on S3C24XX.
Date: Fri, 13 Dec 2013 09:42:03 +0100 [thread overview]
Message-ID: <201312130942.03674.heiko@sntech.de> (raw)
In-Reply-To: <CACRpkdbBqqbkp3ap3Y=C5zC3Cq9jd+dL4iPZ9-2-Fd81GLAPBA@mail.gmail.com>
Am Freitag, 13. Dezember 2013, 09:12:52 schrieb Linus Walleij:
> On Fri, Dec 13, 2013 at 2:55 AM, José Miguel Gonçalves
>
> <jose.goncalves@inov.pt> wrote:
> > On 27-09-2013 15:17, Linus Walleij wrote:
> >> On Wed, Sep 11, 2013 at 10:46 AM, José Miguel Gonçalves
> >>
> >> <jose.goncalves@inov.pt> wrote:
> >>> Some GPIO line limits are incorrectly set which, for instance,
> >>> does not allow nRTS1 (GPH11) configuration on a S3C2416 chip.
> >>>
> >>> Signed-off-by: José Miguel Gonçalves <jose.goncalves@inov.pt>
> >>> ---
> >>>
> >>> arch/arm/mach-s3c24xx/include/mach/gpio.h | 10 +++++-----
>
> (...)
>
> > Was this patch forgotten?
>
> Not by me, I just never got an ACK from the Samsung maintainers,
> so I can't apply it to the GPIO tree.
>
> Ben, Kukjin: can one of you ACK this so I can take it through the
> GPIO tree?
again not the maintainer :-), but I've looked through the manuals of s3c24xx
socs and the new values look correct [I had looked up the patch content in the
list archive], so
Acked-by: Heiko Stuebner <heiko@sntech.de>
But Jose, you should really really look into moving to devicetree with your
platform, if you're not already doing so. Pinctrl support is already present,
and I'm hopefull the move to the common clock framework I posted a few days
ago might make it too.
Heiko
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-12-13 8:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-11 8:46 [PATCH] ARM: S3C24XX: Fix configuration of gpio port sizes on S3C24XX José Miguel Gonçalves
2013-09-11 16:27 ` Heiko Stübner
2013-09-27 14:17 ` Linus Walleij
2013-12-13 1:55 ` José Miguel Gonçalves
2013-12-13 8:12 ` Linus Walleij
2013-12-13 8:42 ` Heiko Stübner [this message]
2013-12-13 9:38 ` José Miguel Gonçalves
2013-12-13 9:24 ` kgene
2013-12-13 9:29 ` Heiko Stübner
2013-12-13 9:37 ` Linus Walleij
2013-12-20 9:12 ` Linus Walleij
2013-12-20 20:57 ` Kukjin Kim
2014-01-02 12:53 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201312130942.03674.heiko@sntech.de \
--to=heiko@sntech.de \
--cc=ben-linux@fluff.org \
--cc=jose.goncalves@inov.pt \
--cc=kgene.kim@samsung.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=t.figa@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).