From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Westerberg Subject: Re: [PATCH v3 4/6] gpio / ACPI: register to ACPI events automatically Date: Wed, 8 Jan 2014 12:22:24 +0200 Message-ID: <20140108102224.GO2494@intel.com> References: <1385460350-17543-1-git-send-email-mika.westerberg@linux.intel.com> <1385460350-17543-5-git-send-email-mika.westerberg@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mga02.intel.com ([134.134.136.20]:39686 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755224AbaAHKPZ (ORCPT ); Wed, 8 Jan 2014 05:15:25 -0500 Content-Disposition: inline In-Reply-To: Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Linus Walleij Cc: ACPI Devel Maling List , "Rafael J. Wysocki" , Chris Ball , Johannes Berg , Rhyland Klein , Adrian Hunter , Alexandre Courbot , Mathias Nyman , Rob Landley , Heikki Krogerus , Stephen Warren , Thierry Reding , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" On Tue, Jan 07, 2014 at 06:50:00PM +0100, Linus Walleij wrote: > On Tue, Nov 26, 2013 at 11:05 AM, Mika Westerberg > wrote: > > > Instead of asking each driver to register to ACPI events we can just call > > acpi_gpiochip_register_interrupts() for each chip that has an ACPI handle. > > The function checks chip->to_irq and if it is set to NULL (a GPIO driver > > that doesn't do interrupts) the function does nothing. > > > > We also add the a new header drivers/gpio/gpiolib.h that is used for > > functions internal to gpiolib and add ACPI GPIO chip registering functions > > to that header. > > > > Once that is done we can remove call to acpi_gpiochip_register_interrupts() > > from its only user, pinctrl-baytrail.c > > > > Signed-off-by: Mika Westerberg > > Acked-by: Rafael J. Wysocki > > Two questions: > > - Can you please rebase patches 3-6 on my GPIO tree "devel" branch? Yes. > - Can this patch be placed first? It does not seem to depend on the > others, to to push dependent patches to the end of the series. Sure - I'll post a rebased version in a moment.