From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gerhard Sittig Subject: Re: [PATCH] gpio: mcp23s08: Trivial: Fixed coding style issues Date: Wed, 12 Mar 2014 21:16:06 +0100 Message-ID: <20140312201606.GN3327@book.gsilab.sittig.org> References: <1394148326-21556-1-git-send-email-garyservin@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Linus Walleij Cc: Gary Servin , Alexandre Courbot , Jiri Kosina , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" List-Id: linux-gpio@vger.kernel.org On Wed, Mar 12, 2014 at 14:53 +0100, Linus Walleij wrote: > > On Fri, Mar 7, 2014 at 12:25 AM, Gary Servin wrote: > > > This coding style issue was detected using the checkpatch.pl script > > > > Signed-off-by: Gary Servin > > Sometimes the compiler is just too forgiving :-/ > Thanks a lot for fixing this, patch applied. I think the code had no syntax or language issue before. The cleanup really was about style exclusively (which still is a good thing). 'sizeof' is an operator, very much like a unary minus or unary ampersand which neither require parentheses. So either of "sizeof(x)" as well as "sizeof x" are legal with regard to the C language. It's just that the community prefers "sizeof(x)" for the improved readability. virtually yours Gerhard Sittig -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr. 5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office@denx.de