From: Arnd Bergmann <arnd@arndb.de>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: "Russell King - ARM Linux" <linux@arm.linux.org.uk>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"arm@kernel.org" <arm@kernel.org>,
"Simon Kågström" <simon.kagstrom@netinsight.net>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"Krzysztof Halasa" <khc@pm.waw.pl>
Subject: Re: [PATCH 1/3] IXP4xx: Fix Goramo Multilink GPIO conversion.
Date: Wed, 26 Mar 2014 23:06:43 +0100 [thread overview]
Message-ID: <201403262306.43920.arnd@arndb.de> (raw)
In-Reply-To: <CACRpkdaNdQjgAJv=mxn6MXS+kGKFoE4wmNHxYt_5WdM9sa6vxA@mail.gmail.com>
On Monday 24 March 2014, Linus Walleij wrote:
> On Sun, Mar 23, 2014 at 1:34 AM, Krzysztof Halasa <khc@pm.waw.pl> wrote:
>
> > arch/arm/mach-ixp4xx/goramo_mlr.c: In function 'set_scl':
> > arch/arm/mach-ixp4xx/goramo_mlr.c:82: error: implicit declaration of function 'gpio_line_set'
> >
> > arch/arm/mach-ixp4xx/goramo_mlr.c: In function 'output_control':
> > arch/arm/mach-ixp4xx/goramo_mlr.c:111: error: implicit declaration of function 'gpio_line_config'
> > arch/arm/mach-ixp4xx/goramo_mlr.c:111: error: 'IXP4XX_GPIO_OUT' undeclared
> >
> > arch/arm/mach-ixp4xx/goramo_mlr.c: In function 'hss_dcd_irq':
> > arch/arm/mach-ixp4xx/goramo_mlr.c:155: error: implicit declaration of function 'gpio_line_get'
> >
> > arch/arm/mach-ixp4xx/goramo_mlr.c: In function 'gmlr_init':
> > arch/arm/mach-ixp4xx/goramo_mlr.c:416: error: 'IXP4XX_GPIO_OUT' undeclared
> > arch/arm/mach-ixp4xx/goramo_mlr.c:421: error: 'IXP4XX_GPIO_IN' undeclared
> >
> > Signed-off-by: Krzysztof Hałasa <khc@pm.waw.pl>
>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
>
> Mea culpa.
>
> Arnd: can you apply this one patch directly for ARM SoC fixes and
> Cc: stable@vger.kernel.org on this one?
>
> Alternatively can you send this for fixes to arm@kernel.org with Cc:
> stable added Krzysztof?
I reverted my earlier patch and applied this instead. Thanks a lot!
Did not add a stable tag, as suggested by Krzysztof.
Arnd
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2014-03-26 22:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <m3siq9iyt2.fsf@intrepid.localdomain>
[not found] ` <m3bnwxiwhj.fsf@intrepid.localdomain>
2014-03-24 15:27 ` [PATCH 1/3] IXP4xx: Fix Goramo Multilink GPIO conversion Linus Walleij
2014-03-24 20:36 ` Krzysztof Halasa
2014-03-26 22:06 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201403262306.43920.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=arm@kernel.org \
--cc=khc@pm.waw.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=simon.kagstrom@netinsight.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox