linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	Peter Tyser <ptyser@xes-inc.com>,
	Mathias Nyman <mathias.nyman@linux.intel.com>,
	ACPI Devel Maling List <linux-acpi@vger.kernel.org>
Subject: Re: Adding interrupt support to gpio-ich driver (possibly via SCI)
Date: Tue, 8 Apr 2014 04:31:14 +0100	[thread overview]
Message-ID: <20140408033114.GA28159@srcf.ucam.org> (raw)
In-Reply-To: <53436B1C.8010102@roeck-us.net>

On Mon, Apr 07, 2014 at 08:21:00PM -0700, Guenter Roeck wrote:
> On 04/07/2014 07:48 PM, Matthew Garrett wrote:
> >You shouldn't need to install an SCI handler - the way the hardware will
> >generate an SCI is to raise a GPE. If you know which GPE the device
> >raises (my recollection is that for most Intel chipsets it's GPIO number
> >+ 0x10) then you can just call acpi_install_gpe_handler(). The problem
> 
> Sounds good. Do you by any chance have a pointer to some documentation
> explaining this in some more detail ?

The SCI is just IRQ 9 - it tells the OS that there's a firmware event, 
but in itself doesn't say what that event was. This is handled by the 
platform setting bits in the GPE*_STS registers. The ACPI code reads 
that and then dispatches the event to the appropriate handler. This will 
typically be some ACPI code (declared by _Lxx and _Exx methods in the 
ACPI tables - xx corresponds to the GPE number, L and E whether it's 
level or edge triggered), but in some cases you want to install a 
hardcoded event handler.

I've only got the 5-series docs to hand, and I can't remember whether 
that's Panther Point, but you want to look at the definition of GPE0_STS 
to figure out which hardware events cause which GPEs. GPEs 16 to 31 
appear to correspond to GPIO 0 to 15, which is easy enough to handle.

> >is that the firmware may well already be using some of those GPIOs, and
> >there's no easy way to tell. Checking the interrupt configuration isn't
> >sufficient, since some of them may just be used as outputs.
> >
> The gpio-ich driver already has some magic to detect that condition - I
> noticed that I can not request all GPIO pins on all hardware. Either case,
> the gpio pins I am interested in are well defined on the hardware I am
> dealing with, so I can be sure I won't step on some unexpected use.

Ok. As long as you don't reprogram anything by default, I think this 
should be fine.

-- 
Matthew Garrett | mjg59@srcf.ucam.org

  reply	other threads:[~2014-04-08  3:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-04 16:25 Adding interrupt support to gpio-ich driver (possibly via SCI) Guenter Roeck
2014-04-08  2:48 ` Matthew Garrett
2014-04-08  3:21   ` Guenter Roeck
2014-04-08  3:31     ` Matthew Garrett [this message]
2014-04-08  4:02       ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140408033114.GA28159@srcf.ucam.org \
    --to=mjg59@srcf.ucam.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=mathias.nyman@linux.intel.com \
    --cc=ptyser@xes-inc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).