Oops in acpi_gpiochip_add on MacBookPro with Linux v3.14-12042-g69cd9eba3886

Oops in acpi_gpiochip_add on MacBookPro with Linux v3.14-12042-g69cd9eba3886

[Josh Boyer]

Hi All,

With Linux v3.14-12042-g69cd9eba3886 I get an oops from the bcma
module on the MacBookPro 10,2 I have here.  This works fine with Linux
v3.14-7333-g59ecc26004e7.  There have been no changes between those
two versions to bcma itself, but the GPIO merge did go in that window.
 I can attempt to do a bisect tomorrow, but looking over some of the
GPIO commits it seems pretty relevant to the ACPI GPIO changes.  I'm
hoping someone here has an idea on what the issue might be and has
some possible things for me to test for fixes.

I've transcribed the oops below by hand from a pic I took of the oops
because it doesn't wind up in the logs.  The pic itself can be
accessed here:

https://drive.google.com/file/d/0B03YtBX8ablKdC10NTdmQnBidVk/

josh

bcma: bus0: Found chip with id 0x4331, rev 0x02, and package 0x09
bcma: bus0: Core 0 found: ChipCommon (manuf 0x4BF, id 0x800, rev 0x25,
class 0x0)
bcma: bus0: Core 1 found: IEEE 802.11 (manuf 0x4BF, id 0x812, rev
0x1D, class 0x0)
bcma: bus0: Core 2 found: PCIe (manuf 0x4BF, id 0x820, rev 0x13, class 0x0)
BUG: unable to handle kernel NULL pointer dereference at 00000000000003d8
IP: [<ffffffff81400765>] acpi_gpiochip_add+0x15/0x1c0
PGD 0
Oops: 0000 [#1] SMP
Modules linked in: snd_pcm(+) sdhci_pci(+) i2c_i801 bcma(+) sdhci mmc_core....
CPU: 1 PID: 636 Comm: systemd-udevd Not tainted 3.15.0-0.rc0.git10.1.fc21.x86_64
Hardware name: Apple Inc. MacBookPro10,2/Mac-AFD8A9D944EA4843, BIOS
MBP102.88Z.01...
task: ffff880.....
RIP: 0010:[<ffffffff81400765>] [<ffffffff81400765>] acpi_gpiochip_add+0x15/0x1c0
....
Call Trace:
gpiochip_add
bcma_gpio_init
bcma_bus_register
bcma_host_pci_probe
local_pci_probe
? pci_match_device
pci_device_probe
driver_probe_device
__driver_attach
? __driver_attach
bus_for_each_dev
driver_attach
bus_add_driver
? bcma_bus_early_register
driver_register
? bcma_bus_early_register
__pci_register_driver
bcma_host_pci_init
bcma_modinit
do_one_initcall
? set_memory_nx
load_module
? store_uevent
? kernel_read
SyS_finit_module
system_call_fastpath

Re: Oops in acpi_gpiochip_add on MacBookPro with Linux v3.14-12042-g69cd9eba3886

[Rafał Miłecki]

2014-04-09 23:09 GMT+02:00 Josh Boyer <jwboyer@fedoraproject.org>:
> With Linux v3.14-12042-g69cd9eba3886 I get an oops from the bcma
> module on the MacBookPro 10,2 I have here.  This works fine with Linux
> v3.14-7333-g59ecc26004e7.  There have been no changes between those
> two versions to bcma itself, but the GPIO merge did go in that window.
>  I can attempt to do a bisect tomorrow, but looking over some of the
> GPIO commits it seems pretty relevant to the ACPI GPIO changes.  I'm
> hoping someone here has an idea on what the issue might be and has
> some possible things for me to test for fixes.

Bug report: https://lkml.org/lkml/2014/3/24/262
Patch: https://lkml.org/lkml/2014/3/24/293
Tested by Sabrina: https://lkml.org/lkml/2014/3/24/304
(all links are for the same thread).

Now you simply have to find above patch in some git tree :) Not sure
if it's already in Linus's one.

Re: Oops in acpi_gpiochip_add on MacBookPro with Linux v3.14-12042-g69cd9eba3886

[Josh Boyer]

On Thu, Apr 10, 2014 at 2:50 AM, Rafał Miłecki <zajec5@gmail.com> wrote:
> 2014-04-09 23:09 GMT+02:00 Josh Boyer <jwboyer@fedoraproject.org>:
>> With Linux v3.14-12042-g69cd9eba3886 I get an oops from the bcma
>> module on the MacBookPro 10,2 I have here.  This works fine with Linux
>> v3.14-7333-g59ecc26004e7.  There have been no changes between those
>> two versions to bcma itself, but the GPIO merge did go in that window.
>>  I can attempt to do a bisect tomorrow, but looking over some of the
>> GPIO commits it seems pretty relevant to the ACPI GPIO changes.  I'm
>> hoping someone here has an idea on what the issue might be and has
>> some possible things for me to test for fixes.
>
> Bug report: https://lkml.org/lkml/2014/3/24/262
> Patch: https://lkml.org/lkml/2014/3/24/293
> Tested by Sabrina: https://lkml.org/lkml/2014/3/24/304
> (all links are for the same thread).
>
> Now you simply have to find above patch in some git tree :) Not sure
> if it's already in Linus's one.

Ah, wonderful.  I now wish I would have found those in my searching
before doing the bisect.  Oh well.  For what it's worth, my bisect
landed on the same commit.

The fix isn't in Linus' tree or linux-next.  I'm guessing Mika is
either still on vacation, or hasn't sent out the formal fix yet.

josh
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Oops in acpi_gpiochip_add on MacBookPro with Linux v3.14-12042-g69cd9eba3886

[Mika Westerberg]

On Thu, Apr 10, 2014 at 08:22:12AM -0400, Josh Boyer wrote:
> On Thu, Apr 10, 2014 at 2:50 AM, Rafał Miłecki <zajec5@gmail.com> wrote:
> > 2014-04-09 23:09 GMT+02:00 Josh Boyer <jwboyer@fedoraproject.org>:
> >> With Linux v3.14-12042-g69cd9eba3886 I get an oops from the bcma
> >> module on the MacBookPro 10,2 I have here.  This works fine with Linux
> >> v3.14-7333-g59ecc26004e7.  There have been no changes between those
> >> two versions to bcma itself, but the GPIO merge did go in that window.
> >>  I can attempt to do a bisect tomorrow, but looking over some of the
> >> GPIO commits it seems pretty relevant to the ACPI GPIO changes.  I'm
> >> hoping someone here has an idea on what the issue might be and has
> >> some possible things for me to test for fixes.
> >
> > Bug report: https://lkml.org/lkml/2014/3/24/262
> > Patch: https://lkml.org/lkml/2014/3/24/293
> > Tested by Sabrina: https://lkml.org/lkml/2014/3/24/304
> > (all links are for the same thread).
> >
> > Now you simply have to find above patch in some git tree :) Not sure
> > if it's already in Linus's one.
> 
> Ah, wonderful.  I now wish I would have found those in my searching
> before doing the bisect.  Oh well.  For what it's worth, my bisect
> landed on the same commit.
> 
> The fix isn't in Linus' tree or linux-next.  I'm guessing Mika is
> either still on vacation, or hasn't sent out the formal fix yet.

No, not on vacation anymore (unfortunately). I did send the formal patch
already:

https://lkml.org/lkml/2014/3/31/135

but it isn't merged to Linus' GPIO tree yet.
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Oops in acpi_gpiochip_add on MacBookPro with Linux v3.14-12042-g69cd9eba3886

[Josh Boyer]

On Thu, Apr 10, 2014 at 8:40 AM, Mika Westerberg
<mika.westerberg-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> wrote:
> On Thu, Apr 10, 2014 at 08:22:12AM -0400, Josh Boyer wrote:
>> On Thu, Apr 10, 2014 at 2:50 AM, Rafał Miłecki <zajec5@gmail.com> wrote:
>> > 2014-04-09 23:09 GMT+02:00 Josh Boyer <jwboyer-rxtnV0ftBwyoClj4AeEUq9i2O/JbrIOy@public.gmane.org>:
>> >> With Linux v3.14-12042-g69cd9eba3886 I get an oops from the bcma
>> >> module on the MacBookPro 10,2 I have here.  This works fine with Linux
>> >> v3.14-7333-g59ecc26004e7.  There have been no changes between those
>> >> two versions to bcma itself, but the GPIO merge did go in that window.
>> >>  I can attempt to do a bisect tomorrow, but looking over some of the
>> >> GPIO commits it seems pretty relevant to the ACPI GPIO changes.  I'm
>> >> hoping someone here has an idea on what the issue might be and has
>> >> some possible things for me to test for fixes.
>> >
>> > Bug report: https://lkml.org/lkml/2014/3/24/262
>> > Patch: https://lkml.org/lkml/2014/3/24/293
>> > Tested by Sabrina: https://lkml.org/lkml/2014/3/24/304
>> > (all links are for the same thread).
>> >
>> > Now you simply have to find above patch in some git tree :) Not sure
>> > if it's already in Linus's one.
>>
>> Ah, wonderful.  I now wish I would have found those in my searching
>> before doing the bisect.  Oh well.  For what it's worth, my bisect
>> landed on the same commit.
>>
>> The fix isn't in Linus' tree or linux-next.  I'm guessing Mika is
>> either still on vacation, or hasn't sent out the formal fix yet.
>
> No, not on vacation anymore (unfortunately). I did send the formal patch
> already:
>
> https://lkml.org/lkml/2014/3/31/135
>
> but it isn't merged to Linus' GPIO tree yet.

Ah, ok great.  I'll test that today.  Thanks.

josh
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Oops in acpi_gpiochip_add on MacBookPro with Linux v3.14-12042-g69cd9eba3886

[Josh Boyer]

On Thu, Apr 10, 2014 at 8:52 AM, Josh Boyer <jwboyer@fedoraproject.org> wrote:
> On Thu, Apr 10, 2014 at 8:40 AM, Mika Westerberg
> <mika.westerberg@linux.intel.com> wrote:
>> On Thu, Apr 10, 2014 at 08:22:12AM -0400, Josh Boyer wrote:
>>> On Thu, Apr 10, 2014 at 2:50 AM, Rafał Miłecki <zajec5@gmail.com> wrote:
>>> > 2014-04-09 23:09 GMT+02:00 Josh Boyer <jwboyer@fedoraproject.org>:
>>> >> With Linux v3.14-12042-g69cd9eba3886 I get an oops from the bcma
>>> >> module on the MacBookPro 10,2 I have here.  This works fine with Linux
>>> >> v3.14-7333-g59ecc26004e7.  There have been no changes between those
>>> >> two versions to bcma itself, but the GPIO merge did go in that window.
>>> >>  I can attempt to do a bisect tomorrow, but looking over some of the
>>> >> GPIO commits it seems pretty relevant to the ACPI GPIO changes.  I'm
>>> >> hoping someone here has an idea on what the issue might be and has
>>> >> some possible things for me to test for fixes.
>>> >
>>> > Bug report: https://lkml.org/lkml/2014/3/24/262
>>> > Patch: https://lkml.org/lkml/2014/3/24/293
>>> > Tested by Sabrina: https://lkml.org/lkml/2014/3/24/304
>>> > (all links are for the same thread).
>>> >
>>> > Now you simply have to find above patch in some git tree :) Not sure
>>> > if it's already in Linus's one.
>>>
>>> Ah, wonderful.  I now wish I would have found those in my searching
>>> before doing the bisect.  Oh well.  For what it's worth, my bisect
>>> landed on the same commit.
>>>
>>> The fix isn't in Linus' tree or linux-next.  I'm guessing Mika is
>>> either still on vacation, or hasn't sent out the formal fix yet.
>>
>> No, not on vacation anymore (unfortunately). I did send the formal patch
>> already:
>>
>> https://lkml.org/lkml/2014/3/31/135
>>
>> but it isn't merged to Linus' GPIO tree yet.
>
> Ah, ok great.  I'll test that today.  Thanks.

Yep, that works for my bcma issue as well.  Thanks!

Tested-by: Josh Boyer <jwboyer@fedoraproject.org>

josh
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Oops in acpi_gpiochip_add on MacBookPro with Linux v3.14-12042-g69cd9eba3886

[Linus Walleij]

On Thu, Apr 10, 2014 at 2:40 PM, Mika Westerberg
<mika.westerberg@linux.intel.com> wrote:
> On Thu, Apr 10, 2014 at 08:22:12AM -0400, Josh Boyer wrote:
>> On Thu, Apr 10, 2014 at 2:50 AM, Rafał Miłecki <zajec5@gmail.com> wrote:
>> > 2014-04-09 23:09 GMT+02:00 Josh Boyer <jwboyer@fedoraproject.org>:
>> >> With Linux v3.14-12042-g69cd9eba3886 I get an oops from the bcma
>> >> module on the MacBookPro 10,2 I have here.  This works fine with Linux
>> >> v3.14-7333-g59ecc26004e7.  There have been no changes between those
>> >> two versions to bcma itself, but the GPIO merge did go in that window.
>> >>  I can attempt to do a bisect tomorrow, but looking over some of the
>> >> GPIO commits it seems pretty relevant to the ACPI GPIO changes.  I'm
>> >> hoping someone here has an idea on what the issue might be and has
>> >> some possible things for me to test for fixes.
>> >
>> > Bug report: https://lkml.org/lkml/2014/3/24/262
>> > Patch: https://lkml.org/lkml/2014/3/24/293
>> > Tested by Sabrina: https://lkml.org/lkml/2014/3/24/304
>> > (all links are for the same thread).
>> >
>> > Now you simply have to find above patch in some git tree :) Not sure
>> > if it's already in Linus's one.
>>
>> Ah, wonderful.  I now wish I would have found those in my searching
>> before doing the bisect.  Oh well.  For what it's worth, my bisect
>> landed on the same commit.
>>
>> The fix isn't in Linus' tree or linux-next.  I'm guessing Mika is
>> either still on vacation, or hasn't sent out the formal fix yet.
>
> No, not on vacation anymore (unfortunately). I did send the formal patch
> already:
>
> https://lkml.org/lkml/2014/3/31/135
>
> but it isn't merged to Linus' GPIO tree yet.

I've queued this for fixes!

Will send upstream ASAP.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Oops in acpi_gpiochip_add on MacBookPro with Linux v3.14-12042-g69cd9eba3886

[Mika Westerberg]

On Thu, Apr 10, 2014 at 08:47:23PM +0200, Linus Walleij wrote:
> On Thu, Apr 10, 2014 at 2:40 PM, Mika Westerberg
> <mika.westerberg@linux.intel.com> wrote:
> > On Thu, Apr 10, 2014 at 08:22:12AM -0400, Josh Boyer wrote:
> >> On Thu, Apr 10, 2014 at 2:50 AM, Rafał Miłecki <zajec5@gmail.com> wrote:
> >> > 2014-04-09 23:09 GMT+02:00 Josh Boyer <jwboyer@fedoraproject.org>:
> >> >> With Linux v3.14-12042-g69cd9eba3886 I get an oops from the bcma
> >> >> module on the MacBookPro 10,2 I have here.  This works fine with Linux
> >> >> v3.14-7333-g59ecc26004e7.  There have been no changes between those
> >> >> two versions to bcma itself, but the GPIO merge did go in that window.
> >> >>  I can attempt to do a bisect tomorrow, but looking over some of the
> >> >> GPIO commits it seems pretty relevant to the ACPI GPIO changes.  I'm
> >> >> hoping someone here has an idea on what the issue might be and has
> >> >> some possible things for me to test for fixes.
> >> >
> >> > Bug report: https://lkml.org/lkml/2014/3/24/262
> >> > Patch: https://lkml.org/lkml/2014/3/24/293
> >> > Tested by Sabrina: https://lkml.org/lkml/2014/3/24/304
> >> > (all links are for the same thread).
> >> >
> >> > Now you simply have to find above patch in some git tree :) Not sure
> >> > if it's already in Linus's one.
> >>
> >> Ah, wonderful.  I now wish I would have found those in my searching
> >> before doing the bisect.  Oh well.  For what it's worth, my bisect
> >> landed on the same commit.
> >>
> >> The fix isn't in Linus' tree or linux-next.  I'm guessing Mika is
> >> either still on vacation, or hasn't sent out the formal fix yet.
> >
> > No, not on vacation anymore (unfortunately). I did send the formal patch
> > already:
> >
> > https://lkml.org/lkml/2014/3/31/135
> >
> > but it isn't merged to Linus' GPIO tree yet.
> 
> I've queued this for fixes!
> 
> Will send upstream ASAP.

Thanks!