From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH 4/7] net: rfkill: gpio: fix reversed clock enable state Date: Tue, 15 Apr 2014 16:27:00 +0200 Message-ID: <20140415142700.GF3207@lukather> References: <1397544101-18135-1-git-send-email-wens@csie.org> <1397544101-18135-5-git-send-email-wens@csie.org> Reply-To: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="2FkSFaIQeDFoAt0B" Return-path: Content-Disposition: inline In-Reply-To: <1397544101-18135-5-git-send-email-wens-jdAy2FN1RRM@public.gmane.org> List-Post: , List-Help: , List-Archive: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org List-Subscribe: , List-Unsubscribe: , To: Chen-Yu Tsai Cc: Linus Walleij , Johannes Berg , "John W. Linville" , Arnd Bergmann , Heikki Krogerus , Mika Westerberg , Alexandre Courbot , Stephen Warren , linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org List-Id: linux-gpio@vger.kernel.org --2FkSFaIQeDFoAt0B Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Apr 15, 2014 at 02:41:38PM +0800, Chen-Yu Tsai wrote: > rfkill-gpio has clk_enabled =3D blocked, which is true when rfkill > blocks the device. This results in calling clock enable/disable at > the wrong time. Reversing the value fixes this. >=20 > Signed-off-by: Chen-Yu Tsai Acked-by: Maxime Ripard Thanks! Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --2FkSFaIQeDFoAt0B Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) iQIbBAEBAgAGBQJTTUG0AAoJEBx+YmzsjxAg6CEP93OnZUrmCgxusnW1kCg8OUN3 OJXIJEg+vKvI3AkFuKDN5l5CVmWngT1TnaRj4TvPOza1YaL+TorEIKIxZUEhj+QV AP1ViZW+xUJhC6Ky6dYKp3UI7s3xh28Vev6tuPI+G26B+FfAwTp0nVmujXyBT0cD CL3CgLCCS5SBBaZonIIL9roHdhBoZJUseFyXNSCmYDBnp0keMxpz3CBs5WnFaE0o 3vE+KUWoYy90WzbxiZjxaqxAiHOHL2gkev0XQFusvr31ZeZ15KkdZILfo9YXVhTT /u0XkQXh1D16QKZWnoW072pNwZSm/XezbSLUp+XJRVETa3X6PI7GNyhba0U7i8J6 Q0gqZAUC2chIRBzcR0P9rYqAQztDjxFRwSJIiYB+z470Igw0t3VSFg4VQY3NKpP0 g1XIM320KquxHsDxY0jNw7ITTxYDIEzj+mbJYPgvO4coommUbuTfVInp/+a6jlXi byiALmU4Ol8qv9vhU7FTaeQiC/TbVcwp8PF4rKGojb1CRg10vTDDFbZNkUCrZcSI noZSGdzKgOymtUN/SQFnA83m19lAUJkjJnVfZ32JGCNq97oBiL9DmGDSHpCnhsl7 4eA9srwBuZmbS9cTJTCoMhKUpUq6DXI8yZ487jikrmtZTSrUD1reC27PK9heh/rE DhFHwxwBAR3+gTbpBdU= =7eiL -----END PGP SIGNATURE----- --2FkSFaIQeDFoAt0B--