From: Lee Jones <lee.jones@linaro.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-gpio@vger.kernel.org,
Alexandre Courbot <acourbot@nvidia.com>,
Samuel Ortiz <sameo@linux.intel.com>
Subject: Re: [PATCH 3/4] gpio: tc3589x: get rid of static IRQ base
Date: Thu, 17 Apr 2014 08:47:42 +0100 [thread overview]
Message-ID: <20140417074742.GD28725@lee--X1> (raw)
In-Reply-To: <1397044139-19306-1-git-send-email-linus.walleij@linaro.org>
> The static IRQ base is not used on any platforms with this chip
> (only Ux500). Get rid of it forever, and rely on dynamic IRQ
> descriptor allocation.
>
> Cc: Samuel Ortiz <sameo@linux.intel.com>
> Cc: Lee Jones <lee.jones@linaro.org>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> drivers/gpio/gpio-tc3589x.c | 10 +---------
> include/linux/mfd/tc3589x.h | 1 -
> 2 files changed, 1 insertion(+), 10 deletions(-)
>
> diff --git a/drivers/gpio/gpio-tc3589x.c b/drivers/gpio/gpio-tc3589x.c
> index 113e50cb1f59..4b0d8ccbe561 100644
> --- a/drivers/gpio/gpio-tc3589x.c
> +++ b/drivers/gpio/gpio-tc3589x.c
> @@ -32,9 +32,6 @@ struct tc3589x_gpio {
> struct device *dev;
> struct mutex irq_lock;
> struct irq_domain *domain;
> -
> - int irq_base;
> -
> /* Caches of interrupt control registers for bus_lock */
> u8 regs[CACHE_NR_REGS][CACHE_NR_BANKS];
> u8 oldregs[CACHE_NR_REGS][CACHE_NR_BANKS];
> @@ -290,8 +287,6 @@ static struct irq_domain_ops tc3589x_irq_ops = {
> static int tc3589x_gpio_irq_init(struct tc3589x_gpio *tc3589x_gpio,
> struct device_node *np)
> {
> - int base = tc3589x_gpio->irq_base;
> -
> /*
> * If this results in a linear domain, irq_create_mapping() will
> * take care of allocating IRQ descriptors at runtime. When a base
> @@ -299,7 +294,7 @@ static int tc3589x_gpio_irq_init(struct tc3589x_gpio *tc3589x_gpio,
> * domain is instantiated.
> */
> tc3589x_gpio->domain = irq_domain_add_simple(np,
> - tc3589x_gpio->chip.ngpio, base, &tc3589x_irq_ops,
> + tc3589x_gpio->chip.ngpio, 0, &tc3589x_irq_ops,
> tc3589x_gpio);
> if (!tc3589x_gpio->domain) {
> dev_err(tc3589x_gpio->dev, "Failed to create irqdomain\n");
> @@ -348,9 +343,6 @@ static int tc3589x_gpio_probe(struct platform_device *pdev)
> tc3589x_gpio->chip.of_node = np;
> #endif
>
> - tc3589x_gpio->irq_base = tc3589x->irq_base ?
> - tc3589x->irq_base + TC3589x_INT_GPIO(0) : 0;
> -
> /* Bring the GPIO module out of reset */
> ret = tc3589x_set_bits(tc3589x, TC3589x_RSTCTRL,
> TC3589x_RSTCTRL_GPIRST, 0);
> diff --git a/include/linux/mfd/tc3589x.h b/include/linux/mfd/tc3589x.h
> index 6b8e1ff4672b..e6088c2e2092 100644
> --- a/include/linux/mfd/tc3589x.h
> +++ b/include/linux/mfd/tc3589x.h
> @@ -111,7 +111,6 @@ enum tx3589x_block {
> #define TC3589x_INT_PORIRQ 7
>
> #define TC3589x_NR_INTERNAL_IRQS 8
> -#define TC3589x_INT_GPIO(x) (TC3589x_NR_INTERNAL_IRQS + (x))
>
> struct tc3589x {
> struct mutex lock;
Does this actually compile? Does this patch have a dependency?
I see TC3589x_INT_GPIO(x) being used still:
include/linux/mfd/tc3589x.h:
#define TC3589x_NR_IRQS TC3589x_INT_GPIO(TC3589x_NR_GPIOS)
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-04-17 7:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-09 11:48 [PATCH 3/4] gpio: tc3589x: get rid of static IRQ base Linus Walleij
2014-04-17 7:47 ` Lee Jones [this message]
2014-04-23 12:16 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140417074742.GD28725@lee--X1 \
--to=lee.jones@linaro.org \
--cc=acourbot@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).