* [PATCH] input: gpio-keys: Move the gpio-keys bindings documentation
@ 2014-05-12 14:33 Ezequiel Garcia
2014-05-12 17:58 ` Dmitry Torokhov
2014-05-18 20:30 ` Linus Walleij
0 siblings, 2 replies; 5+ messages in thread
From: Ezequiel Garcia @ 2014-05-12 14:33 UTC (permalink / raw)
To: devicetree, linux-gpio, linux-input
Cc: Dmitry Torokhov, Linus Walleij, Ezequiel Garcia
This is an input driver and belongs to input not gpio.
Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
---
.../devicetree/bindings/gpio/gpio_keys.txt | 36 ----------------------
.../devicetree/bindings/input/gpio-keys.txt | 36 ++++++++++++++++++++++
2 files changed, 36 insertions(+), 36 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/gpio/gpio_keys.txt
create mode 100644 Documentation/devicetree/bindings/input/gpio-keys.txt
diff --git a/Documentation/devicetree/bindings/gpio/gpio_keys.txt b/Documentation/devicetree/bindings/gpio/gpio_keys.txt
deleted file mode 100644
index 5c2c021..0000000
--- a/Documentation/devicetree/bindings/gpio/gpio_keys.txt
+++ /dev/null
@@ -1,36 +0,0 @@
-Device-Tree bindings for input/gpio_keys.c keyboard driver
-
-Required properties:
- - compatible = "gpio-keys";
-
-Optional properties:
- - autorepeat: Boolean, Enable auto repeat feature of Linux input
- subsystem.
-
-Each button (key) is represented as a sub-node of "gpio-keys":
-Subnode properties:
-
- - gpios: OF device-tree gpio specification.
- - label: Descriptive name of the key.
- - linux,code: Keycode to emit.
-
-Optional subnode-properties:
- - linux,input-type: Specify event type this button/key generates.
- If not specified defaults to <1> == EV_KEY.
- - debounce-interval: Debouncing interval time in milliseconds.
- If not specified defaults to 5.
- - gpio-key,wakeup: Boolean, button can wake-up the system.
-
-Example nodes:
-
- gpio_keys {
- compatible = "gpio-keys";
- #address-cells = <1>;
- #size-cells = <0>;
- autorepeat;
- button@21 {
- label = "GPIO Key UP";
- linux,code = <103>;
- gpios = <&gpio1 0 1>;
- };
- ...
diff --git a/Documentation/devicetree/bindings/input/gpio-keys.txt b/Documentation/devicetree/bindings/input/gpio-keys.txt
new file mode 100644
index 0000000..5c2c021
--- /dev/null
+++ b/Documentation/devicetree/bindings/input/gpio-keys.txt
@@ -0,0 +1,36 @@
+Device-Tree bindings for input/gpio_keys.c keyboard driver
+
+Required properties:
+ - compatible = "gpio-keys";
+
+Optional properties:
+ - autorepeat: Boolean, Enable auto repeat feature of Linux input
+ subsystem.
+
+Each button (key) is represented as a sub-node of "gpio-keys":
+Subnode properties:
+
+ - gpios: OF device-tree gpio specification.
+ - label: Descriptive name of the key.
+ - linux,code: Keycode to emit.
+
+Optional subnode-properties:
+ - linux,input-type: Specify event type this button/key generates.
+ If not specified defaults to <1> == EV_KEY.
+ - debounce-interval: Debouncing interval time in milliseconds.
+ If not specified defaults to 5.
+ - gpio-key,wakeup: Boolean, button can wake-up the system.
+
+Example nodes:
+
+ gpio_keys {
+ compatible = "gpio-keys";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ autorepeat;
+ button@21 {
+ label = "GPIO Key UP";
+ linux,code = <103>;
+ gpios = <&gpio1 0 1>;
+ };
+ ...
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] input: gpio-keys: Move the gpio-keys bindings documentation
2014-05-12 14:33 [PATCH] input: gpio-keys: Move the gpio-keys bindings documentation Ezequiel Garcia
@ 2014-05-12 17:58 ` Dmitry Torokhov
2014-05-15 14:22 ` Ezequiel Garcia
2014-05-18 20:30 ` Linus Walleij
1 sibling, 1 reply; 5+ messages in thread
From: Dmitry Torokhov @ 2014-05-12 17:58 UTC (permalink / raw)
To: Ezequiel Garcia; +Cc: devicetree, linux-gpio, linux-input, Linus Walleij
On Mon, May 12, 2014 at 11:33:44AM -0300, Ezequiel Garcia wrote:
> This is an input driver and belongs to input not gpio.
>
> Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Fine by me, will DT guys pick the patch or shoudl I do it?
Thanks!
> ---
> .../devicetree/bindings/gpio/gpio_keys.txt | 36 ----------------------
> .../devicetree/bindings/input/gpio-keys.txt | 36 ++++++++++++++++++++++
> 2 files changed, 36 insertions(+), 36 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/gpio/gpio_keys.txt
> create mode 100644 Documentation/devicetree/bindings/input/gpio-keys.txt
>
> diff --git a/Documentation/devicetree/bindings/gpio/gpio_keys.txt b/Documentation/devicetree/bindings/gpio/gpio_keys.txt
> deleted file mode 100644
> index 5c2c021..0000000
> --- a/Documentation/devicetree/bindings/gpio/gpio_keys.txt
> +++ /dev/null
> @@ -1,36 +0,0 @@
> -Device-Tree bindings for input/gpio_keys.c keyboard driver
> -
> -Required properties:
> - - compatible = "gpio-keys";
> -
> -Optional properties:
> - - autorepeat: Boolean, Enable auto repeat feature of Linux input
> - subsystem.
> -
> -Each button (key) is represented as a sub-node of "gpio-keys":
> -Subnode properties:
> -
> - - gpios: OF device-tree gpio specification.
> - - label: Descriptive name of the key.
> - - linux,code: Keycode to emit.
> -
> -Optional subnode-properties:
> - - linux,input-type: Specify event type this button/key generates.
> - If not specified defaults to <1> == EV_KEY.
> - - debounce-interval: Debouncing interval time in milliseconds.
> - If not specified defaults to 5.
> - - gpio-key,wakeup: Boolean, button can wake-up the system.
> -
> -Example nodes:
> -
> - gpio_keys {
> - compatible = "gpio-keys";
> - #address-cells = <1>;
> - #size-cells = <0>;
> - autorepeat;
> - button@21 {
> - label = "GPIO Key UP";
> - linux,code = <103>;
> - gpios = <&gpio1 0 1>;
> - };
> - ...
> diff --git a/Documentation/devicetree/bindings/input/gpio-keys.txt b/Documentation/devicetree/bindings/input/gpio-keys.txt
> new file mode 100644
> index 0000000..5c2c021
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/gpio-keys.txt
> @@ -0,0 +1,36 @@
> +Device-Tree bindings for input/gpio_keys.c keyboard driver
> +
> +Required properties:
> + - compatible = "gpio-keys";
> +
> +Optional properties:
> + - autorepeat: Boolean, Enable auto repeat feature of Linux input
> + subsystem.
> +
> +Each button (key) is represented as a sub-node of "gpio-keys":
> +Subnode properties:
> +
> + - gpios: OF device-tree gpio specification.
> + - label: Descriptive name of the key.
> + - linux,code: Keycode to emit.
> +
> +Optional subnode-properties:
> + - linux,input-type: Specify event type this button/key generates.
> + If not specified defaults to <1> == EV_KEY.
> + - debounce-interval: Debouncing interval time in milliseconds.
> + If not specified defaults to 5.
> + - gpio-key,wakeup: Boolean, button can wake-up the system.
> +
> +Example nodes:
> +
> + gpio_keys {
> + compatible = "gpio-keys";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + autorepeat;
> + button@21 {
> + label = "GPIO Key UP";
> + linux,code = <103>;
> + gpios = <&gpio1 0 1>;
> + };
> + ...
> --
> 1.9.1
>
--
Dmitry
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] input: gpio-keys: Move the gpio-keys bindings documentation
2014-05-12 17:58 ` Dmitry Torokhov
@ 2014-05-15 14:22 ` Ezequiel Garcia
0 siblings, 0 replies; 5+ messages in thread
From: Ezequiel Garcia @ 2014-05-15 14:22 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: devicetree, linux-gpio, linux-input, Linus Walleij
On 12 May 10:58 AM, Dmitry Torokhov wrote:
> On Mon, May 12, 2014 at 11:33:44AM -0300, Ezequiel Garcia wrote:
> > This is an input driver and belongs to input not gpio.
> >
> > Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
>
> Fine by me, will DT guys pick the patch or shoudl I do it?
>
I'd say it's just a small file movement, so go for it!
BTW, forgot to prepare the patch with rename detection, want me to resend it?
--
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] input: gpio-keys: Move the gpio-keys bindings documentation
2014-05-12 14:33 [PATCH] input: gpio-keys: Move the gpio-keys bindings documentation Ezequiel Garcia
2014-05-12 17:58 ` Dmitry Torokhov
@ 2014-05-18 20:30 ` Linus Walleij
2014-05-18 20:42 ` Dmitry Torokhov
1 sibling, 1 reply; 5+ messages in thread
From: Linus Walleij @ 2014-05-18 20:30 UTC (permalink / raw)
To: Ezequiel Garcia
Cc: devicetree@vger.kernel.org, linux-gpio@vger.kernel.org,
Linux Input, Dmitry Torokhov
On Mon, May 12, 2014 at 4:33 PM, Ezequiel Garcia
<ezequiel.garcia@free-electrons.com> wrote:
> This is an input driver and belongs to input not gpio.
>
> Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] input: gpio-keys: Move the gpio-keys bindings documentation
2014-05-18 20:30 ` Linus Walleij
@ 2014-05-18 20:42 ` Dmitry Torokhov
0 siblings, 0 replies; 5+ messages in thread
From: Dmitry Torokhov @ 2014-05-18 20:42 UTC (permalink / raw)
To: Linus Walleij
Cc: Ezequiel Garcia, devicetree@vger.kernel.org,
linux-gpio@vger.kernel.org, Linux Input
On Sun, May 18, 2014 at 10:30:26PM +0200, Linus Walleij wrote:
> On Mon, May 12, 2014 at 4:33 PM, Ezequiel Garcia
> <ezequiel.garcia@free-electrons.com> wrote:
>
> > This is an input driver and belongs to input not gpio.
> >
> > Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
>
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
Applied, thank you.
--
Dmitry
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-05-18 20:42 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-12 14:33 [PATCH] input: gpio-keys: Move the gpio-keys bindings documentation Ezequiel Garcia
2014-05-12 17:58 ` Dmitry Torokhov
2014-05-15 14:22 ` Ezequiel Garcia
2014-05-18 20:30 ` Linus Walleij
2014-05-18 20:42 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).