* [PATCH] gpio: Add run-time dependencies to R-Car driver
@ 2014-05-23 11:42 Jean Delvare
2014-05-26 0:54 ` Simon Horman
2014-05-27 13:45 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Jean Delvare @ 2014-05-23 11:42 UTC (permalink / raw)
To: linux-gpio; +Cc: Magnus Damm, Simon Horman, Linus Walleij, Alexandre Courbot
The Renesas R-Car GPIO driver is only useful on shmobile unless build
testing.
Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: Magnus Damm <damm@opensource.se>
Cc: Simon Horman <horms+renesas@verge.net.au>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Alexandre Courbot <gnurou@gmail.com>
---
Simon, is it correct? I couldn't remove the dependency on ARM because
the driver uses set_irq_flags which is arm-specific.
drivers/gpio/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-3.15-rc6.orig/drivers/gpio/Kconfig 2014-05-23 12:00:02.262995319 +0200
+++ linux-3.15-rc6/drivers/gpio/Kconfig 2014-05-23 13:29:01.773035079 +0200
@@ -259,7 +259,7 @@ config GPIO_PXA
config GPIO_RCAR
tristate "Renesas R-Car GPIO"
- depends on ARM
+ depends on ARM && (ARCH_SHMOBILE || COMPILE_TEST)
help
Say yes here to support GPIO on Renesas R-Car SoCs.
--
Jean Delvare
SUSE L3 Support
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gpio: Add run-time dependencies to R-Car driver
2014-05-23 11:42 [PATCH] gpio: Add run-time dependencies to R-Car driver Jean Delvare
@ 2014-05-26 0:54 ` Simon Horman
2014-05-27 13:45 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2014-05-26 0:54 UTC (permalink / raw)
To: Jean Delvare; +Cc: linux-gpio, Magnus Damm, Linus Walleij, Alexandre Courbot
On Fri, May 23, 2014 at 01:42:14PM +0200, Jean Delvare wrote:
> The Renesas R-Car GPIO driver is only useful on shmobile unless build
> testing.
>
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Cc: Magnus Damm <damm@opensource.se>
> Cc: Simon Horman <horms+renesas@verge.net.au>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Alexandre Courbot <gnurou@gmail.com>
> ---
> Simon, is it correct? I couldn't remove the dependency on ARM because
> the driver uses set_irq_flags which is arm-specific.
Assuming that set_irq_flags is arm-specific then yes, I think this is
correct.
Acked-by: Simon Horman <horms+renesas@verge.net.au>
>
> drivers/gpio/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-3.15-rc6.orig/drivers/gpio/Kconfig 2014-05-23 12:00:02.262995319 +0200
> +++ linux-3.15-rc6/drivers/gpio/Kconfig 2014-05-23 13:29:01.773035079 +0200
> @@ -259,7 +259,7 @@ config GPIO_PXA
>
> config GPIO_RCAR
> tristate "Renesas R-Car GPIO"
> - depends on ARM
> + depends on ARM && (ARCH_SHMOBILE || COMPILE_TEST)
> help
> Say yes here to support GPIO on Renesas R-Car SoCs.
>
>
>
> --
> Jean Delvare
> SUSE L3 Support
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gpio: Add run-time dependencies to R-Car driver
2014-05-23 11:42 [PATCH] gpio: Add run-time dependencies to R-Car driver Jean Delvare
2014-05-26 0:54 ` Simon Horman
@ 2014-05-27 13:45 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2014-05-27 13:45 UTC (permalink / raw)
To: Jean Delvare
Cc: linux-gpio@vger.kernel.org, Magnus Damm, Simon Horman,
Alexandre Courbot
On Fri, May 23, 2014 at 1:42 PM, Jean Delvare <jdelvare@suse.de> wrote:
> The Renesas R-Car GPIO driver is only useful on shmobile unless build
> testing.
>
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Cc: Magnus Damm <damm@opensource.se>
> Cc: Simon Horman <horms+renesas@verge.net.au>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Alexandre Courbot <gnurou@gmail.com>
Patch applied with Simon's ACK.
> Simon, is it correct? I couldn't remove the dependency on ARM because
> the driver uses set_irq_flags which is arm-specific.
We usually #ifdef CONFIG_ARM around that function call actually.
But now, we also do that in the core gpiolib irqchip helpers, so just
switch this driver to use the irqchip helpers and you can drop the ARM
dependency.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-05-27 13:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-23 11:42 [PATCH] gpio: Add run-time dependencies to R-Car driver Jean Delvare
2014-05-26 0:54 ` Simon Horman
2014-05-27 13:45 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).