From: Ralf Baechle <ralf@linux-mips.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: abdoulaye berthe <berthe.ab@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>,
m@bues.ch,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Linux MIPS Mailing List <linux-mips@linux-mips.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
Linux-sh list <linux-sh@vger.kernel.org>,
linux-wireless <linux-wireless@vger.kernel.org>,
patches@opensource.wolfsonmicro.com,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"linux-leds@vger.kernel.org" <linux-leds@vger.kernel.org>,
Linux Media Mailing List <linux-media@vger.kernel.org>,
linux-samsungsoc@vger.kernel.org, spear-devel@list.st.com,
platform-driver-x86@vger.kernel.org"netdev@vger.kernel.org" <ne>
Subject: Re: [PATCH 2/2] gpio: gpiolib: set gpiochip_remove retval to void
Date: Fri, 30 May 2014 17:48:59 +0200 [thread overview]
Message-ID: <20140530154859.GK17197@linux-mips.org> (raw)
In-Reply-To: <CAMuHMdV6AtjD2aqO3buzj8Eo7A7xc_+ROYnxEi2sdjMaqFiAuA@mail.gmail.com>
On Fri, May 30, 2014 at 01:39:15PM +0200, Geert Uytterhoeven wrote:
> > + if (test_bit(FLAG_REQUESTED, &chip->desc[id].flags))
> > + panic("gpio: removing gpiochip with gpios still requested\n");
>
> panic?
>
> Is this likely to happen?
And while we're at it - panic() is going to add a \n itself so don't pass a
string ending in \n to panic().
Ralf
next prev parent reply other threads:[~2014-05-30 15:48 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-29 21:54 [PATCH] gpio: removes all usage of gpiochip_remove retval abdoulaye berthe
2014-05-29 22:14 ` David Daney
2014-05-29 23:16 ` abdoulaye berthe
2014-05-29 23:40 ` Stephen Rothwell
2014-05-30 11:30 ` [PATCH 1/2] " abdoulaye berthe
2014-05-30 11:30 ` [PATCH 2/2] gpio: gpiolib: set gpiochip_remove retval to void abdoulaye berthe
2014-05-30 11:39 ` Geert Uytterhoeven
2014-05-30 15:48 ` Ralf Baechle [this message]
2014-05-30 17:33 ` David Daney
2014-05-30 18:16 ` Lars-Peter Clausen
2014-05-30 23:29 ` Greg KH
2014-05-31 7:35 ` Lars-Peter Clausen
2014-05-31 12:19 ` Dan Carpenter
2014-06-08 23:18 ` Ben Dooks
2014-06-09 11:29 ` Lars-Peter Clausen
2014-06-09 13:15 ` Andrzej Hajda
2014-06-09 13:43 ` David Laight
2014-06-10 6:57 ` Andrzej Hajda
2014-05-30 11:37 ` [PATCH 1/2] gpio: removes all usage of gpiochip_remove retval abdoulaye berthe
2014-05-30 11:37 ` [PATCH 2/2] gpio: gpiolib: set gpiochip_remove retval to void abdoulaye berthe
2014-05-30 15:59 ` [PATCH 1/2] gpio: removes all usage of gpiochip_remove retval Alexandre Courbot
2014-06-04 18:22 ` [PATCH 0/2] gpiochip remove abdoulaye berthe
2014-06-04 18:22 ` [PATCH 1/2] gpio: removes all usage of gpiochip_remove retval abdoulaye berthe
2014-07-04 22:35 ` Linus Walleij
2014-07-05 16:28 ` [PATCH 2/2] gpio: gpiolib: set gpiochip_remove retval to void abdoulaye berthe
2014-07-05 20:28 ` [PATCH] gpio: removes all usage of gpiochip_remove retval abdoulaye berthe
2014-07-09 7:45 ` Linus Walleij
2014-07-12 20:30 ` [PATCH 0/3] remove all usage of gpio_remove retval abdoulaye berthe
2014-07-12 20:30 ` [PATCH 1/1] gpio: remove all usage of gpio_remove retval in driver/gpio abdoulaye berthe
2014-07-12 20:30 ` [PATCH 2/2] pinctrl: remove all usage of gpio_remove ret val in driver/pinctl abdoulaye berthe
2014-07-22 14:34 ` Linus Walleij
2014-07-12 20:30 ` [PATCH 3/3] driver:gpio remove all usage of gpio_remove retval in driver abdoulaye berthe
2014-07-22 15:08 ` Linus Walleij
2014-07-22 15:11 ` Mark Brown
2014-07-24 8:29 ` Linus Walleij
2014-07-22 15:17 ` Michael Büsch
2014-07-22 16:01 ` Lee Jones
2014-07-22 17:51 ` Dmitry Torokhov
2014-07-22 19:17 ` Mauro Carvalho Chehab
2014-07-29 11:30 ` Tomi Valkeinen
2014-06-04 18:22 ` [PATCH 2/2] gpio: gpiolib: set gpiochip_remove retval to void abdoulaye berthe
2014-06-08 12:12 ` Alexandre Courbot
2014-06-09 21:22 ` abdoulaye berthe
2014-07-04 22:55 ` Linus Walleij
2014-06-04 18:35 ` [PATCH 0/2] gpiochip remove abdoulaye berthe
2014-05-29 23:25 ` [PATCH] gpio: removes all usage of gpiochip_remove retval Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140530154859.GK17197@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=berthe.ab@gmail.com \
--cc=geert@linux-m68k.org \
--cc=gnurou@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-samsungsoc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=m@bues.ch \
--cc=patches@opensource.wolfsonmicro.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=spear-devel@list.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).