From: Tony Lindgren <tony@atomide.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Alexandre Courbot <gnurou@gmail.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-omap@vger.kernel.org
Subject: Re: [PATCH 2/2] gpio: of: Allow -gpio suffix for property names
Date: Mon, 2 Jun 2014 16:04:58 -0700 [thread overview]
Message-ID: <20140602230457.GE11004@atomide.com> (raw)
In-Reply-To: <CACRpkdbF3N5bFY1sFkabDHO7J0F8sb1uU0xL+mjkuF-z7VocMQ@mail.gmail.com>
* Linus Walleij <linus.walleij@linaro.org> [140425 00:53]:
> On Wed, Apr 23, 2014 at 5:28 PM, Thierry Reding
> <thierry.reding@gmail.com> wrote:
>
> > From: Thierry Reding <treding@nvidia.com>
> >
> > Many bindings use the -gpio suffix in property names. Support this in
> > addition to the -gpios suffix when requesting GPIOs using the new
> > descriptor-based API.
> >
> > Signed-off-by: Thierry Reding <treding@nvidia.com>
>
> It appears this can save quite a lot of code in drivers, work that
> I trust Thierry to persue based on this to some extent so patch is
> tentatively applied unless something comes up.
Looks like this patch causes a regression where GPIOs on I2C will
no longer return -EPROBE_DEFER but seem to return -ENOENT instead.
This breaks drivers using things like devm_gpiod_get_index()
on a GPIO that's on a I2C bus not probed yet.
Reverting commit dd34c37aa3e (gpio: of: Allow -gpio suffix for
property names) fixes things.
Regards,
Tony
next prev parent reply other threads:[~2014-06-02 23:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-23 15:28 [PATCH 1/2] gpio: of: Remove unneeded dummy function Thierry Reding
2014-04-23 15:28 ` [PATCH 2/2] gpio: of: Allow -gpio suffix for property names Thierry Reding
2014-04-24 12:47 ` Linus Walleij
2014-04-24 14:06 ` Rob Herring
2014-04-24 18:22 ` Thierry Reding
2014-04-25 15:24 ` Stephen Warren
2014-05-02 22:22 ` Linus Walleij
2014-04-25 7:38 ` Alexandre Courbot
2014-04-25 7:52 ` Linus Walleij
2014-06-02 23:04 ` Tony Lindgren [this message]
2014-06-02 23:14 ` Tony Lindgren
2014-06-04 13:08 ` Thierry Reding
2014-06-12 8:18 ` Linus Walleij
2014-04-24 12:43 ` [PATCH 1/2] gpio: of: Remove unneeded dummy function Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140602230457.GE11004@atomide.com \
--to=tony@atomide.com \
--cc=gnurou@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).