From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH 3/3] driver:gpio remove all usage of gpio_remove retval in driver Date: Tue, 22 Jul 2014 10:51:22 -0700 Message-ID: <20140722175121.GA5489@core.coreip.homeip.net> References: <1405197014-25225-1-git-send-email-berthe.ab@gmail.com> <1405197014-25225-4-git-send-email-berthe.ab@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Linus Walleij Cc: linux-mips@linux-mips.org, "linux-fbdev@vger.kernel.org" , "linux-sh@vger.kernel.org" , Benjamin Herrenschmidt , "alsa-devel@alsa-project.org" , "linux-kernel@vger.kernel.org" , Lee Jones , Matthew Garrett , Samuel Ortiz , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , Tomi Valkeinen , "linux-serial@vger.kernel.org" , Linux Input , abdoulaye berthe , Alexandre Courbot , Bryan Wu , "arm@kernel.org" , "linux-gpio@vger.kernel.org" , Mark Brown , Michael List-Id: linux-gpio@vger.kernel.org On Tue, Jul 22, 2014 at 05:08:13PM +0200, Linus Walleij wrote: > On Sat, Jul 12, 2014 at 10:30 PM, abdoulaye berthe wrote: > > Heads up. Requesting ACKs for this patch or I'm atleast warning that it will be > applied. We're getting rid of the return value from gpiochip_remove(). > > > this remove all reference to gpio_remove retval in all driver > > except pinctrl and gpio. the same thing is done for gpio and > > pinctrl in two different patches. > > > > Signed-off-by: abdoulaye berthe > (...) > > I think this patch probably needs to be broken down per-subsystem as it > hits all over the map. But let's start requesting ACKs for the > individual pieces. > Actually I think it will be OK to merge because there is likely not much churn > around these code sites. > > I'm a bit torn between just wanting a big patch for this hitting drivers/gpio > and smaller patches hitting one subsystem at a time. We should be able > to hammer this in one switch strike. ... > > > drivers/input/keyboard/adp5588-keys.c | 4 +--- > > drivers/input/keyboard/adp5589-keys.c | 4 +--- > > drivers/input/touchscreen/ad7879.c | 10 +++------- > > Dmitry can you ACK this? Acked-by: Dmitry Torokhov -- Dmitry