Re: [PATCH 2/2] pinctrl: sunxi: number gpio ranges starting from 0

[Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1137 bytes --]

On Thu, Jul 24, 2014 at 09:19:18PM +0800, Chen-Yu Tsai wrote:
> > This patch also changes the GPIO bindings for R_PIO:
> >
> >     gpios = <&r_pio B N flag>;
> >
> > Where B originally was the pinbank label (L or M) counted from A,
> > with this patch it becomes (L or M) counted from its pinbank base (L).
> >
> > Thus
> >
> >     gpios = <&r_pio 10 11 0>; /* PL11 */
> >
> > becomes
> >
> >     gpios = <&r_pio 0 11 0>; /* PL11 */
> >
> > IMO this is correct, as the binding shows the bank offset and pin offset
> > within the bank for the GPIO controller. But I'm worried it might be a
> > bit confusing.
> 
> I see you Acked this patch, but also in your reply to my cover letter,
> you mentioned that you want absolute pin numbers matching the datasheets.
> What about the GPIO DT bindings, as I explained above?
> 
> Just double checking. Thanks.

I'd like it to have the absolute numbers in sysfs, but the relative
one in the DT. But I guess it's already what's happening, right?

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]