From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Alexandre Courbot <acourbot@nvidia.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
gnurou@gmail.com
Subject: Re: [PATCH 2/2] gpio: change gpiochip_request_own_desc() prototype
Date: Tue, 19 Aug 2014 12:34:12 +0300 [thread overview]
Message-ID: <20140819093412.GK1660@lahna.fi.intel.com> (raw)
In-Reply-To: <1408380657-6718-3-git-send-email-acourbot@nvidia.com>
On Mon, Aug 18, 2014 at 09:50:57AM -0700, Alexandre Courbot wrote:
> The current prototype of gpiochip_request_own_desc() requires to obtain
> a pointer to a descriptor. This is in contradiction to all other GPIO
> request schemes, and imposes an extra step of obtaining a descriptor to
> drivers. Most drivers actually cannot even perform that step since the
> function that does it (gpichip_get_desc()) is gpiolib-private.
>
> Change gpiochip_request_own_desc() to return a descriptor from a
> (chip, hwnum) tuple and update users of this function (currently
> gpiolib-acpi only).
>
> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
Tested on Asus T100TA and everything still seems to work so,
Tested-by: Mika Westerberg <mika.westerberg@linux.intel.com>
prev parent reply other threads:[~2014-08-19 9:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-18 16:50 [PATCH 0/2] gpio: acpi: some sanity fixes Alexandre Courbot
2014-08-18 16:50 ` [PATCH 1/2] gpio: acpi: normalize use of gpiochip_get_desc() Alexandre Courbot
2014-08-19 9:32 ` Mika Westerberg
2014-08-19 16:59 ` Alexandre Courbot
2014-08-18 16:50 ` [PATCH 2/2] gpio: change gpiochip_request_own_desc() prototype Alexandre Courbot
2014-08-19 9:34 ` Mika Westerberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140819093412.GK1660@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=acourbot@nvidia.com \
--cc=gnurou@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).