From: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Weike Chen <alvin.chen@intel.com>,
Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>,
Grant Likely <grant.likely@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
atull <atull@opensource.altera.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org,
Boon Leong Ong <boon.leong.ong@intel.com>,
Hock Leong Kweh <hock.leong.kweh@intel.com>,
Darren Hart <dvhart@linux.intel.com>,
Mika Westerberg <mika.westerberg@intel.com>,
Andriy Shevchenko <andriy.shevchenko@intel.com>
Subject: Re: [PATCH 1/3 v2] GPIO: gpio-dwapb: Enable platform driver binding to MFD driver
Date: Fri, 5 Sep 2014 21:37:36 +0200 [thread overview]
Message-ID: <20140905193736.GA7981@breakpoint.cc> (raw)
In-Reply-To: <3465722.Gc9y01nQRe@wuerfel>
On 2014-09-05 13:50:06 [+0200], Arnd Bergmann wrote:
> On Friday 05 September 2014 07:53:16 Weike Chen wrote:
> >
> > - irq_set_chained_handler(irq, dwapb_irq_handler);
> > - irq_set_handler_data(irq, gpio);
> > + if (!pp->irq_shared) {
> > + irq_set_chained_handler(pp->irq, dwapb_irq_handler);
> > + irq_set_handler_data(pp->irq, gpio);
> > + } else {
> > + /*
> > + * Request a shared IRQ since where MFD would have devices
> > + * using the same irq pin
> > + */
> > + err = devm_request_irq(gpio->dev, pp->irq,
> > + dwapb_irq_handler_mfd,
> > + IRQF_SHARED, "gpio-dwapb-mfd", gpio);
> > + if (err) {
> > + dev_err(gpio->dev, "error requesting IRQ\n");
> > + irq_domain_remove(gpio->domain);
> > + gpio->domain = NULL;
> > + return;
> > + }
> > + }
> >
>
> I think this need some better documentation. Why is it safe to use
> devm_request_irq rather than irq_set_chained_handler here?
Usually it is preferred to use irq_set_chained_handler() for the chained
handler so the handler does not show up in /proc/interrupts.
This requires an exclusive non-shared handler which is not the case on
the intel platform. So they have to use devm_request_irq() instead.
Sebastian
next prev parent reply other threads:[~2014-09-05 19:37 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-05 14:53 [PATCH 0/3 v2] The Designware GPIO Supporting Weike Chen
2014-09-05 14:53 ` [PATCH 1/3 v2] GPIO: gpio-dwapb: Enable platform driver binding to MFD driver Weike Chen
2014-09-05 9:21 ` Shevchenko, Andriy
2014-09-05 10:20 ` Chen, Alvin
2014-09-05 12:02 ` Shevchenko, Andriy
2014-09-05 12:20 ` Arnd Bergmann
2014-09-09 1:50 ` Chen, Alvin
2014-09-09 9:01 ` Shevchenko, Andriy
2014-09-05 11:50 ` Arnd Bergmann
2014-09-05 19:37 ` Sebastian Andrzej Siewior [this message]
2014-09-06 10:47 ` Chen, Alvin
2014-09-09 1:20 ` Chen, Alvin
2014-09-05 14:53 ` [PATCH 2/3 v2] GPIO: gpio-dwapb: Support Debounce Weike Chen
2014-09-05 9:23 ` Shevchenko, Andriy
2014-09-05 9:35 ` Chen, Alvin
2014-09-05 12:03 ` Shevchenko, Andriy
2014-09-09 0:47 ` Chen, Alvin
2014-09-05 14:53 ` [PATCH 3/3 v2] GPIO: gpio-dwapb: Suspend & Resume PM enabling Weike Chen
2014-09-05 9:24 ` Shevchenko, Andriy
2014-09-05 9:35 ` Chen, Alvin
2014-09-19 17:34 ` Linus Walleij
2014-09-22 1:37 ` Chen, Alvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140905193736.GA7981@breakpoint.cc \
--to=sebastian@breakpoint.cc \
--cc=alvin.chen@intel.com \
--cc=andriy.shevchenko@intel.com \
--cc=arnd@arndb.de \
--cc=atull@opensource.altera.com \
--cc=boon.leong.ong@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dvhart@linux.intel.com \
--cc=gnurou@gmail.com \
--cc=grant.likely@linaro.org \
--cc=hock.leong.kweh@intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@intel.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).