From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shawn Guo Subject: Re: [PATCH v3 4/5] ARM: dts: vf610: use new GPIO support Date: Fri, 26 Sep 2014 09:21:27 +0800 Message-ID: <20140926012126.GC21077@dragon> References: <590a5fbc4f8b552355a93c1002041765352cd1c3.1411662961.git.stefan@agner.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: Received: from mail-bn1bn0108.outbound.protection.outlook.com ([157.56.110.108]:15556 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753179AbaIZBVx (ORCPT ); Thu, 25 Sep 2014 21:21:53 -0400 Content-Disposition: inline In-Reply-To: <590a5fbc4f8b552355a93c1002041765352cd1c3.1411662961.git.stefan@agner.ch> Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Stefan Agner Cc: linus.walleij@linaro.org, gnurou@gmail.com, kernel@pengutronix.de, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bpringlemeir@nbsps.com, l.stach@pengutronix.de On Thu, Sep 25, 2014 at 06:37:08PM +0200, Stefan Agner wrote: > Use GPIO support by adding SD card detection configuration and > GPIO pinmux for Colibri's standard GPIO pins. Attach the GPIO > pins to the iomuxc node to get the GPIO pin settings applied. > > Signed-off-by: Stefan Agner > --- > arch/arm/boot/dts/vf610-colibri.dtsi | 9 +++++++++ > arch/arm/boot/dts/vf610-twr.dts | 1 + > arch/arm/boot/dts/vf610.dtsi | 1 + > 3 files changed, 11 insertions(+) > > diff --git a/arch/arm/boot/dts/vf610-colibri.dtsi b/arch/arm/boot/dts/vf610-colibri.dtsi > index 0cd8343..efd4322 100644 > --- a/arch/arm/boot/dts/vf610-colibri.dtsi > +++ b/arch/arm/boot/dts/vf610-colibri.dtsi > @@ -31,6 +31,7 @@ > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_esdhc1>; > bus-width = <4>; > + cd-gpios = <&gpio2 10 GPIO_ACTIVE_LOW>; > }; > > &fec1 { > @@ -71,6 +72,14 @@ > > &iomuxc { > vf610-colibri { > + pinctrl_gpio_ext: gpio_ext { > + fsl,pins = < > + VF610_PAD_PTD10__GPIO_89 0x22ed /* EXT_IO_0 */ > + VF610_PAD_PTD9__GPIO_88 0x22ed /* EXT_IO_1 */ > + VF610_PAD_PTD26__GPIO_68 0x22ed /* EXT_IO_2 */ > + >; > + }; > + I'm not sure these GPIOs will be set up at anywhere. To set them up, you need to either have pinctrl_gpio_ext referenced by some client device in its pinctrl-* property or put these pins into hog group (see example in arch/arm/boot/dts/vf610-twr.dts). Shawn > pinctrl_esdhc1: esdhc1grp { > fsl,pins = < > VF610_PAD_PTA24__ESDHC1_CLK 0x31ef > diff --git a/arch/arm/boot/dts/vf610-twr.dts b/arch/arm/boot/dts/vf610-twr.dts > index 189b697..3fe8a8f 100644 > --- a/arch/arm/boot/dts/vf610-twr.dts > +++ b/arch/arm/boot/dts/vf610-twr.dts > @@ -116,6 +116,7 @@ > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_esdhc1>; > bus-width = <4>; > + cd-gpios = <&gpio5 6 GPIO_ACTIVE_LOW>; > status = "okay"; > }; > > diff --git a/arch/arm/boot/dts/vf610.dtsi b/arch/arm/boot/dts/vf610.dtsi > index 4d2ec32..467c97e 100644 > --- a/arch/arm/boot/dts/vf610.dtsi > +++ b/arch/arm/boot/dts/vf610.dtsi > @@ -11,6 +11,7 @@ > #include "vf610-pinfunc.h" > #include > #include > +#include > > / { > aliases { > -- > 2.1.0 >