From: Shawn Guo <shawn.guo@freescale.com>
To: Stefan Agner <stefan@agner.ch>
Cc: linus.walleij@linaro.org, gnurou@gmail.com,
kernel@pengutronix.de, linux-gpio@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, bpringlemeir@nbsps.com,
l.stach@pengutronix.de
Subject: Re: [PATCH v3 4/5] ARM: dts: vf610: use new GPIO support
Date: Fri, 26 Sep 2014 22:51:49 +0800 [thread overview]
Message-ID: <20140926145147.GA5737@dragon> (raw)
In-Reply-To: <f3bba83ea15d680c852eb7d6e45de08a@agner.ch>
On Fri, Sep 26, 2014 at 09:40:34AM +0200, Stefan Agner wrote:
> This GPIO's are meant to be used from user space by default. The latest
> implementation of imx_pmx_gpio_request_enable not only takes care of the
> muxing, but also applies the whole pad settings. Hence we do not need
> the pinctrl subsystem to apply it (through pinctrl-* dt properties).
>
> I changed this now in v3, in v2 I had still to use the pinctrl-*
> properties. I like that 3rd version much more, this way the pin only
> really gets muxed when the user uses it (e.g. we save power because the
> pad is disabled when the GPIO is not in use). If the pin needs to be in
> a defined state, then we would have to explicitly configure/enable it
> through a pinctrl-* properties, but this is not the case for these
> external GPIO's.
Ah, yes, you're right. I was still thinking about the way how it worked
before your patch.
Patch applied, thanks.
next prev parent reply other threads:[~2014-09-26 14:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-25 16:37 [PATCH v3 0/5] vf610: Add GPIO support Stefan Agner
2014-09-25 16:37 ` [PATCH v3 1/5] pinctrl: imx: detect uninitialized pins Stefan Agner
2014-09-25 16:37 ` [PATCH v3 2/5] pinctrl: imx: add gpio pinmux support for vf610 Stefan Agner
2014-09-25 16:37 ` [PATCH v3 3/5] gpio: vf610: add gpiolib/IRQ chip driver for Vybrid Stefan Agner
2014-09-25 16:37 ` [PATCH v3 4/5] ARM: dts: vf610: use new GPIO support Stefan Agner
2014-09-26 1:21 ` Shawn Guo
2014-09-26 7:40 ` Stefan Agner
2014-09-26 14:51 ` Shawn Guo [this message]
2014-09-25 16:37 ` [PATCH v3 5/5] Documentation: dts: add bindings for Vybrid GPIO/PORT module Stefan Agner
2014-09-26 1:16 ` [PATCH v3 0/5] vf610: Add GPIO support Shawn Guo
2014-09-26 8:52 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140926145147.GA5737@dragon \
--to=shawn.guo@freescale.com \
--cc=bpringlemeir@nbsps.com \
--cc=gnurou@gmail.com \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).