From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shawn Guo Subject: Re: [PATCH v3 4/5] ARM: dts: vf610: use new GPIO support Date: Fri, 26 Sep 2014 22:51:49 +0800 Message-ID: <20140926145147.GA5737@dragon> References: <590a5fbc4f8b552355a93c1002041765352cd1c3.1411662961.git.stefan@agner.ch> <20140926012126.GC21077@dragon> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Stefan Agner Cc: linus.walleij@linaro.org, gnurou@gmail.com, kernel@pengutronix.de, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bpringlemeir@nbsps.com, l.stach@pengutronix.de List-Id: linux-gpio@vger.kernel.org On Fri, Sep 26, 2014 at 09:40:34AM +0200, Stefan Agner wrote: > This GPIO's are meant to be used from user space by default. The latest > implementation of imx_pmx_gpio_request_enable not only takes care of the > muxing, but also applies the whole pad settings. Hence we do not need > the pinctrl subsystem to apply it (through pinctrl-* dt properties). > > I changed this now in v3, in v2 I had still to use the pinctrl-* > properties. I like that 3rd version much more, this way the pin only > really gets muxed when the user uses it (e.g. we save power because the > pad is disabled when the GPIO is not in use). If the pin needs to be in > a defined state, then we would have to explicitly configure/enable it > through a pinctrl-* properties, but this is not the case for these > external GPIO's. Ah, yes, you're right. I was still thinking about the way how it worked before your patch. Patch applied, thanks.