From: Johan Hovold <johan@kernel.org>
To: Muthu Mani <muth@cypress.com>
Cc: Johan Hovold <johan@kernel.org>,
Samuel Ortiz <sameo@linux.intel.com>,
Lee Jones <lee.jones@linaro.org>,
Wolfram Sang <wsa@the-dreams.de>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Rajaram Regupathy <rera@cypress.com>
Subject: Re: [PATCH 2/3] i2c: add support for Cypress CYUSBS234 USB-I2C adapter
Date: Tue, 30 Sep 2014 12:09:36 +0200 [thread overview]
Message-ID: <20140930100936.GB17834@localhost> (raw)
In-Reply-To: <6876ca326315426889d3dc596a495b23@BY2PR06MB076.namprd06.prod.outlook.com>
On Thu, Sep 25, 2014 at 05:46:16AM +0000, Muthu Mani wrote:
> > > +static int cy_i2c_xfer(struct i2c_adapter *adapter,
> > > + struct i2c_msg *msgs, int num) {
> > > + int ret = 0;
> > > + struct cyusbs_i2c *cy_i2c;
> > > + struct cyusbs23x *cyusbs = (struct cyusbs23x
> > > +*)adapter->algo_data;
> > > +
> > > + dev_dbg(&adapter->dev, "%s\n", __func__);
> > > +
> > > + if (num > 1) {
> > > + dev_err(&adapter->dev, "i2c_msg number is > 1\n");
> > > + return -EIO;
> > > + }
> >
> > Why not handle multiple messages?
>
> This iteration of the driver is designed to handle only a single
> message at a time.
> It can be expanded to handle multiple messages in future.
No, please do that now. It's just a matter of adding a for loop.
Thanks,
Johan
prev parent reply other threads:[~2014-09-30 10:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-22 9:33 [PATCH 2/3] i2c: add support for Cypress CYUSBS234 USB-I2C adapter Muthu Mani
2014-09-22 11:30 ` Johan Hovold
2014-09-25 5:46 ` Muthu Mani
2014-09-30 10:09 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140930100936.GB17834@localhost \
--to=johan@kernel.org \
--cc=gnurou@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=muth@cypress.com \
--cc=rera@cypress.com \
--cc=sameo@linux.intel.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).