From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v3 1/3] mfd: add support for Cypress CYUSBS234 USB Serial Bridge controller Date: Fri, 10 Oct 2014 17:17:18 +0100 Message-ID: <20141010161718.GA8767@lee--X1> References: <1412606587-3323-1-git-send-email-muth@cypress.com> <20141009074029.GL20647@lee--X1> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Muthu Mani Cc: Samuel Ortiz , Wolfram Sang , Linus Walleij , Alexandre Courbot , "gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org" , "linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Rajaram Regupathy , Johan Hovold List-Id: linux-gpio@vger.kernel.org > > -----Original Message----- > > From: Lee Jones [mailto:lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org] > > Sent: Thursday, October 09, 2014 1:10 PM > > To: Muthu Mani > > Cc: Samuel Ortiz; Wolfram Sang; Linus Walleij; Alexandre Courbot; > > gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org; linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux- > > gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux- > > kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; Rajaram Regupathy; Johan Hovold > > Subject: Re: [PATCH v3 1/3] mfd: add support for Cypress CYUSBS234 = USB > > Serial Bridge controller Why is this in here? > > > + cyusbs->usb_dev =3D usb_get_dev(interface_to_usbdev(interfa= ce)); > >=20 > > Can you do this last? Then you can remove the 'error' error path. >=20 > mfd_add_devices would utlimately invoke the cell drivers' probe befor= e returning and cell drivers use usb_dev in their probe. > So, leaving it as such. Can you move it down to just about mfd_add_devices() then. That way can you at least return directly in the other error paths. [...] > > > +MODULE_AUTHOR("Rajaram Regupathy "); > > > +MODULE_AUTHOR("Muthu Mani "); > > > +MODULE_DESCRIPTION("Cypress CYUSBS23x mfd core driver"); > >=20 > > s/mfd/MFD/ >=20 > Is there a typo? Yes mfd should be MFD, as I sed (spelt this way on purpose). --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog