From: David Cohen <david.a.cohen@linux.intel.com>
To: Mathias Nyman <mathias.nyman@linux.intel.com>
Cc: linus.walleij@linaro.org, gnurou@gmail.com,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Mika Westerberg <mika.westerberg@linux.intel.com>
Subject: Re: [RFC/PATCH] gpio/pinctrl: baytrail: move gpio driver from pinctrl to gpio directory
Date: Tue, 14 Oct 2014 10:45:35 -0700 [thread overview]
Message-ID: <20141014174535.GA6516@psi-dev26.jf.intel.com> (raw)
In-Reply-To: <543CFC7F.2070607@linux.intel.com>
Hi Mathias,
On Tue, Oct 14, 2014 at 01:35:43PM +0300, Mathias Nyman wrote:
> On 13.10.2014 22:17, David Cohen wrote:
> > Even though GPIO module on Intel Bay Trail is able to control pin
> > functionality, it's unlikely Linux kernel driver will ever support it
> > since BIOS should handle all pin muxing itself.
> >
> > Currently this driver does not register any pinctrl interface and
> > doesn't call any pinctrl interface. It just uses on internal functions
> > the 'struct pinctrl_gpio_range', which is a weak justification to not be
> > under gpio directory.
> >
>
> This discussion was held when gpio-baytrail was first submitted.
> These threads explain the gpio/pinctrl-baytrail history:
>
> http://marc.info/?l=linux-kernel&m=136981432427668&w=2
> http://marc.info/?l=linux-kernel&m=137113578604763&w=2
> http://marc.info/?l=linux-kernel&m=137155497023054&w=2
Thanks for pointing that out.
>
> A proper pinctrl driver for baytrail is still not yet ruled out
Having it inside pinctrl directory is creating some confusion because
ppl expect it to implement the actual pinctrl interface.
Anyway, the threads above are over 1 year old. Perhaps it was making
sense during that time, but unless somebody is working on pinctrl
interface now, IMHO we're misplacing the driver for too long. It'd
better to move this driver to gpio directory and when/if pinctrl
interface is implemented, we move it back to current place.
Br, David
>
> -Mathias
>
next prev parent reply other threads:[~2014-10-14 17:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-13 19:17 [RFC/PATCH] gpio/pinctrl: baytrail: move gpio driver from pinctrl to gpio directory David Cohen
2014-10-14 10:35 ` Mathias Nyman
2014-10-14 17:45 ` David Cohen [this message]
2014-10-15 7:08 ` Mika Westerberg
2014-10-15 16:55 ` David Cohen
2014-10-16 8:01 ` Mika Westerberg
2014-10-17 1:53 ` David Cohen
2014-10-28 15:10 ` Linus Walleij
2014-10-28 16:42 ` David Cohen
2014-10-30 15:26 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141014174535.GA6516@psi-dev26.jf.intel.com \
--to=david.a.cohen@linux.intel.com \
--cc=gnurou@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathias.nyman@linux.intel.com \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).