From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Westerberg Subject: Re: [PATCH] pinctrl: baytrail: show output gpio state correctly on Intel Baytrail Date: Mon, 3 Nov 2014 11:24:02 +0200 Message-ID: <20141103092402.GA1304@lahna.fi.intel.com> References: <20141013191405.GB29810@saruman> <20141013192404.GB4034@psi-dev26.jf.intel.com> <20141013192632.GC29810@saruman> <20141013193618.GD29810@saruman> <20141028144249.GD8123@saruman> <20141031132005.GB1273@saruman> <20141031162339.GA7136@psi-dev26.jf.intel.com> <20141031184509.GA2224@psi-dev26.jf.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mga09.intel.com ([134.134.136.24]:13617 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750925AbaKCJYH (ORCPT ); Mon, 3 Nov 2014 04:24:07 -0500 Content-Disposition: inline In-Reply-To: <20141031184509.GA2224@psi-dev26.jf.intel.com> Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: David Cohen Cc: Felipe Balbi , Linus Walleij , "linux-kernel@vger.kernel.org" , "linux-gpio@vger.kernel.org" , stable , mathias.nyman@linux.intel.com On Fri, Oct 31, 2014 at 11:45:09AM -0700, David Cohen wrote: > > I think adding the module exit + allowing this driver to be a module > > would be a good approach. Then we don't need to force generic x86 kernel > > binaries to always have this driver. Unless Mathias or Mika knows a > > constraint to force this driver to be builtin only. > > It helps if I CC them when asking for feedback :) > > Mathias, Mika, do you know any constraint that forces pinctrl-baytrail > to be bool? The only constraint that has been keeping this driver as bool is that some machines like, Asus T100, uses ACPI GPIO operation regions for toggling GPIOs to get things like sensor hub powered on. The GPIO operation region code does not yet handle -EPROBE_DEFER so only way to ensure that the operation region is there is to have the driver compiled in to the kernel.