From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v11 1/3] mfd: add support for Diolan DLN-2 devices Date: Mon, 10 Nov 2014 12:57:18 +0000 Message-ID: <20141110125718.GA24004@x1> References: <1415281685-14866-1-git-send-email-octavian.purdila@intel.com> <1415281685-14866-2-git-send-email-octavian.purdila@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-ie0-f172.google.com ([209.85.223.172]:40069 "EHLO mail-ie0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751815AbaKJM5Z (ORCPT ); Mon, 10 Nov 2014 07:57:25 -0500 Received: by mail-ie0-f172.google.com with SMTP id at20so9195028iec.3 for ; Mon, 10 Nov 2014 04:57:25 -0800 (PST) Content-Disposition: inline In-Reply-To: <1415281685-14866-2-git-send-email-octavian.purdila@intel.com> Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Octavian Purdila Cc: gregkh@linuxfoundation.org, linus.walleij@linaro.org, gnurou@gmail.com, wsa@the-dreams.de, sameo@linux.intel.com, arnd@arndb.de, johan@kernel.org, daniel.baluta@intel.com, laurentiu.palcu@intel.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-i2c@vger.kernel.org On Thu, 06 Nov 2014, Octavian Purdila wrote: > This patch implements the USB part of the Diolan USB-I2C/SPI/GPIO > Master Adapter DLN-2. Details about the device can be found here: >=20 > https://www.diolan.com/i2c/i2c_interface.html. >=20 > Information about the USB protocol can be found in the Programmer's > Reference Manual [1], see section 1.7. >=20 > Because the hardware has a single transmit endpoint and a single > receive endpoint the communication between the various DLN2 drivers > and the hardware will be muxed/demuxed by this driver. >=20 > Each DLN2 module will be identified by the handle field within the DL= N2 > message header. If a DLN2 module issues multiple commands in parallel > they will be identified by the echo counter field in the message head= er. >=20 > The DLN2 modules can use the dln2_transfer() function to issue a > command and wait for its response. They can also register a callback > that is going to be called when a specific event id is generated by > the device (e.g. GPIO interrupts). The device uses handle 0 for > sending events. >=20 > [1] https://www.diolan.com/downloads/dln-api-manual.pdf >=20 > Signed-off-by: Octavian Purdila > Reviewed-by: Johan Hovold Great! Thanks Johan. > --- > drivers/mfd/Kconfig | 11 + > drivers/mfd/Makefile | 1 + > drivers/mfd/dln2.c | 763 +++++++++++++++++++++++++++++++++++++= ++++++++++ > include/linux/mfd/dln2.h | 103 +++++++ > 4 files changed, 878 insertions(+) > create mode 100644 drivers/mfd/dln2.c > create mode 100644 include/linux/mfd/dln2.h >=20 > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > index cbdb109..32d7cab 100644 > --- a/drivers/mfd/Kconfig > +++ b/drivers/mfd/Kconfig > @@ -189,6 +189,17 @@ config MFD_DA9063 > Additional drivers must be enabled in order to use the functional= ity > of the device. > =20 > +config MFD_DLN2 > + tristate "Diolan DLN2 support" > + select MFD_CORE > + depends on USB > + help > + I've removed this line and applied the set. I will send out a pull-request to the other Maintainers shortly. [...] --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html