From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: Richard Fitzgerald <rf@opensource.wolfsonmicro.com>,
broonie@kernel.org, linus.walleij@linaro.org, gnurou@gmail.com,
alsa-devel@alsa-project.org, tiwai@suse.de,
patches@opensource.wolfsonmicro.com, lgirdwood@gmail.com,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org
Subject: Re: [PATCH 1/3] mfd: arizona: Add support for CS47L24
Date: Thu, 13 Nov 2014 16:40:17 +0000 [thread overview]
Message-ID: <20141113164017.GA12443@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20141113101228.GE24004@x1>
On Thu, Nov 13, 2014 at 10:12:28AM +0000, Lee Jones wrote:
> On Tue, 11 Nov 2014, Richard Fitzgerald wrote:
>
> > Signed-off-by: Richard Fitzgerald <rf@opensource.wolfsonmicro.com>
> > ---
> > drivers/mfd/Kconfig | 6 +
> > drivers/mfd/Makefile | 3 +
> > drivers/mfd/arizona-core.c | 91 ++-
> > drivers/mfd/arizona-irq.c | 42 +-
> > drivers/mfd/arizona-spi.c | 9 +
> > drivers/mfd/arizona.h | 5 +
> > drivers/mfd/cs47l24-tables.c | 1632 ++++++++++++++++++++++++++++++++++++++
>
> No chance.
>
> Please resend with these in a header file (like all of the others).
>
> I'd also like Charles' Reviewed-by before accepting.
This looks good to me. I don't quite follow what you are
requesting with the header file? This still uses the header file
for the registers but just defining which are available on this
chip.
Reviewed-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Thanks,
Charles
next prev parent reply other threads:[~2014-11-13 16:40 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-11 16:52 [PATCH 0/3] Driver for Cirrus Logic CS47L24 codec Richard Fitzgerald
2014-11-11 17:03 ` [PATCH 1/3] mfd: arizona: Add support for CS47L24 Richard Fitzgerald
2014-11-12 9:34 ` Charles Keepax
2014-11-11 17:04 ` [PATCH 2/3] gpio: " Richard Fitzgerald
2014-11-11 17:16 ` Mark Brown
2014-11-17 6:41 ` Linus Walleij
2014-11-17 9:58 ` Richard Fitzgerald
2014-11-17 15:03 ` Mark Brown
2014-11-11 17:05 ` [PATCH 3/3] ASoC: arizona: Add initial CS47L24 codec driver Richard Fitzgerald
2014-11-18 14:51 ` Mark Brown
2014-11-18 17:34 ` Richard Fitzgerald
2014-11-11 17:15 ` [PATCH 1/3] mfd: arizona: Add support for CS47L24 Richard Fitzgerald
2014-11-13 10:12 ` Lee Jones
2014-11-13 16:24 ` Richard Fitzgerald
2014-11-13 16:40 ` Charles Keepax [this message]
2014-11-17 12:16 ` Lee Jones
2014-11-17 12:54 ` Richard Fitzgerald
2014-11-17 15:01 ` Mark Brown
2014-11-18 11:34 ` Lee Jones
2014-11-18 13:10 ` Richard Fitzgerald
2014-11-17 15:13 ` Charles Keepax
2014-11-18 15:00 ` Mark Brown
2014-11-19 16:51 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141113164017.GA12443@opensource.wolfsonmicro.com \
--to=ckeepax@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=gnurou@gmail.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=rf@opensource.wolfsonmicro.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).