From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "Rafał Miłecki" <zajec5@gmail.com>,
"Arnd Bergmann" <arnd@arndb.de>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Alexandre Courbot" <gnurou@gmail.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"Hauke Mehrtens" <hauke@hauke-m.de>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"Gabor Juhos" <juhosg@openwrt.org>,
"Miguel Gaio" <miguel.gaio@efixo.com>
Subject: Re: [PATCH] gpio: sn54hc595: new driver for GPIO shift registers chipsets
Date: Tue, 9 Dec 2014 10:12:02 +0100 [thread overview]
Message-ID: <20141209091202.GS8739@lukather> (raw)
In-Reply-To: <CAMuHMdVvK1CTB1SKiNgD8zB9qorV=sQwRO66Dbm5zy=jhw82RA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 852 bytes --]
On Mon, Dec 08, 2014 at 05:59:11PM +0100, Geert Uytterhoeven wrote:
> > I think that implementing support for this extra SPI layer will
> > actually require more code/tricks than a separated driver.
>
> Yes, it will require more code, as spi-gpio is more generic than your simple
> implementation. But the end result is more flexible and reusable.
>
> The only thing missing is the programmable OE and reset pins,
> which are assumed hardwired by the gpio-74x164 driver.
> These could be implemented using new gpio-oe and gpio-reset
> properties.
From my (very) vague memories of it, OE was actually supported by
using it as spi-gpio's chip select.
So I'd say that only the gpio-reset should be implemented.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-12-09 9:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-08 14:27 [PATCH] gpio: sn54hc595: new driver for GPIO shift registers chipsets Rafał Miłecki
2014-12-08 14:41 ` Geert Uytterhoeven
2014-12-08 14:47 ` Rafał Miłecki
2014-12-08 15:03 ` Geert Uytterhoeven
2014-12-08 15:23 ` Rafał Miłecki
2014-12-08 15:41 ` Arnd Bergmann
2014-12-08 16:31 ` Rafał Miłecki
2014-12-08 16:56 ` Arnd Bergmann
2014-12-09 9:09 ` Maxime Ripard
2014-12-08 16:59 ` Geert Uytterhoeven
2014-12-09 9:12 ` Maxime Ripard [this message]
2014-12-11 10:36 ` Rafał Miłecki
2014-12-11 11:03 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141209091202.GS8739@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=gnurou@gmail.com \
--cc=hauke@hauke-m.de \
--cc=juhosg@openwrt.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=miguel.gaio@efixo.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).