From: Johan Hovold <johan@kernel.org>
To: Octavian Purdila <octavian.purdila@intel.com>
Cc: linus.walleij@linaro.org, lee.jones@linaro.org, johan@kernel.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org
Subject: Re: [PATCH v2 4/4] mfd: dln2: add suspend/resume functionality
Date: Wed, 7 Jan 2015 11:26:37 +0100 [thread overview]
Message-ID: <20150107102637.GD22905@localhost> (raw)
In-Reply-To: <1418745435-2851-5-git-send-email-octavian.purdila@intel.com>
On Tue, Dec 16, 2014 at 05:57:15PM +0200, Octavian Purdila wrote:
> Without suspend/resume functionality in the USB driver the USB core
> will disconnect and reconnect the DLN2 port and because the GPIO
> framework does not yet support removal of an in-use controller a
> suspend/resume operation will result in a crash.
>
> This patch provides suspend and resume functions for the DLN2 driver
> so that the above scenario is avoided.
>
> Signed-off-by: Octavian Purdila <octavian.purdila@intel.com>
This patch looks good now, but how did you say this device was powered?
If powered by vbus you cannot assume that the device maintains it's
state over a suspend cycle, something which would complicate matters
quite a bit...
Thanks,
Johan
next prev parent reply other threads:[~2015-01-07 10:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-16 15:57 [PATCH v2 0/4] DLN2 fixes related to suspend/resume Octavian Purdila
2014-12-16 15:57 ` [PATCH v2 1/4] gpio: dln2: fix issue when an IRQ is unmasked then enabled Octavian Purdila
2014-12-17 7:51 ` Alexandre Courbot
[not found] ` <1418745435-2851-2-git-send-email-octavian.purdila-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-01-07 9:38 ` Linus Walleij
[not found] ` <1418745435-2851-1-git-send-email-octavian.purdila-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-12-16 15:57 ` [PATCH v2 2/4] gpio: dln2: use bus_sync_unlock instead of scheduling work Octavian Purdila
2014-12-16 15:57 ` [PATCH v2 3/4] mfd: dln2: add start/stop RX URBs helpers Octavian Purdila
[not found] ` <1418745435-2851-4-git-send-email-octavian.purdila-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-01-07 10:22 ` Johan Hovold
2015-01-18 17:49 ` Lee Jones
2014-12-16 15:57 ` [PATCH v2 4/4] mfd: dln2: add suspend/resume functionality Octavian Purdila
2015-01-07 10:26 ` Johan Hovold [this message]
2015-01-07 13:16 ` Octavian Purdila
2015-01-07 14:26 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150107102637.GD22905@localhost \
--to=johan@kernel.org \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=octavian.purdila@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).