From: Johan Hovold <johan@kernel.org>
To: Jamal Mohammad <md.jamalmohiuddin@gmail.com>
Cc: Johan Hovold <johan@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] gpio: gpio-dln2: Added a Blank line after declaration
Date: Fri, 16 Jan 2015 09:51:42 +0100 [thread overview]
Message-ID: <20150116085142.GF30960@localhost> (raw)
In-Reply-To: <CAP8vtK+vHR_7h_SYWfBNDZkAqUbtEdSDqw+AteZWGqoY37tYTQ@mail.gmail.com>
[ Please do not top-post. ]
On Fri, Jan 16, 2015 at 10:22:56AM +0530, Jamal Mohammad wrote:
> I think you are write ... checkpatch.pl was giving the error at the
> line so i added a blank line... i will send an updated patch..
You should not trust checkpatch.pl blindly, and not run it on in-kernel
files either. Use it on your own patches as a way to find (possible)
mistakes before submission.
Johan
prev parent reply other threads:[~2015-01-16 8:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-13 15:09 [PATCH] gpio: gpio-dln2: Added a Blank line after declaration Mohammad Jamal
2015-01-15 17:20 ` Linus Walleij
2015-01-15 18:10 ` Johan Hovold
2015-01-16 4:52 ` Jamal Mohammad
2015-01-16 8:51 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150116085142.GF30960@localhost \
--to=johan@kernel.org \
--cc=gnurou@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=md.jamalmohiuddin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).