From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Stefan Agner <stefan@agner.ch>
Cc: linus.walleij@linaro.org, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org, kernel@pengutronix.de,
shawn.guo@linaro.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] pinctrl: imx: do not implicitly set pin regs to -1
Date: Fri, 6 Feb 2015 20:21:21 +0100 [thread overview]
Message-ID: <20150206192121.GD10842@pengutronix.de> (raw)
In-Reply-To: <1423240256-27210-1-git-send-email-stefan@agner.ch>
Hallo Stefan,
On Fri, Feb 06, 2015 at 05:30:56PM +0100, Stefan Agner wrote:
> - memset(info->pin_regs, 0xff, sizeof(*info->pin_regs) * info->npins);
> +
> + for (i = 0; i < info->npins; i++) {
> + info->pin_regs[i].mux_reg = -1;
> + info->pin_regs[i].conf_reg = -1;
> + }
looks definitely better. Just out of interest, did you check if it
changes the generated code?
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Thanks
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2015-02-06 19:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-06 16:30 [PATCH] pinctrl: imx: do not implicitly set pin regs to -1 Stefan Agner
2015-02-06 19:21 ` Uwe Kleine-König [this message]
2015-02-06 19:40 ` Stefan Agner
2015-03-02 11:45 ` Shawn Guo
2015-03-02 12:59 ` Uwe Kleine-König
2015-03-02 13:42 ` Stefan Agner
2015-03-02 15:53 ` Uwe Kleine-König
2015-03-04 23:23 ` Stefan Agner
2015-03-09 16:18 ` Linus Walleij
2015-03-09 16:18 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150206192121.GD10842@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=kernel@pengutronix.de \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shawn.guo@linaro.org \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).