Re: [PATCH] Fix one issue in pinctrl-cherryview.c

[David Cohen <david.a.cohen@linux.intel.com>]

Hi Mika,

On Thu, Feb 26, 2015 at 09:11:09AM +0200, Westerberg, Mika wrote:
> On Thu, Feb 26, 2015 at 05:10:13AM +0200, Zha, Qipeng wrote:
> >    Hi
> > 
> >    Please check below patch(or attached), thanks.
> > 
> >    this is verified on Intel cherrytrail platform on linux 3.19-rc6.
> 
> In general you should send your patches inline and plain text to the
> interested parties. Please take some time reading Documentation/SubmittingPatches.
> 
> Then do this:
> 
>  1) git format-patch -1
> 
> This results 0001-pinctrl-update-direction_output-function-of-cherryvi.patch
> 
>  2) git send-email --dry-run --to self 0001-pinctrl-update-direction_output-function-of-cherryvi.patch
> 
> Verify that it sends the patch only to you
> 
>  3) git send-email --to self 0001-pinctrl-update-direction_output-function-of-cherryvi.patch
> 
> Verify that the patch formatting and content is ok. If not, apply fixes
> and start from 1).
> 
> Once you are happy with the result you can then send the patch like:
> 
>  4) git send-email --to ... --cc ...
> 
> and everyone is happy :)
> 
> The patch itself looks good to me.

Not sure if I missed something, but where's the patch? :)

Br, David