From: Shawn Guo <shawn.guo@linaro.org>
To: Stefan Agner <stefan@agner.ch>
Cc: linus.walleij@linaro.org, u.kleine-koenig@pengutronix.de,
kernel@pengutronix.de, linux-gpio@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pinctrl: imx: do not implicitly set pin regs to -1
Date: Mon, 2 Mar 2015 19:45:17 +0800 [thread overview]
Message-ID: <20150302114516.GC3040@dragon> (raw)
In-Reply-To: <1423240256-27210-1-git-send-email-stefan@agner.ch>
On Fri, Feb 06, 2015 at 05:30:56PM +0100, Stefan Agner wrote:
> Commit 3dac1918a491 ("pinctrl: imx: detect uninitialized pins") needs
> the values in struct imx_pin_reg to be -1. This has been done in a
> rather unorthodox way by setting the memory to 0xff using memset...
> Use a proper for loop to initialize the whole array with -1.
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
Acked-by: Shawn Guo <shawn.guo@linaro.org>
next prev parent reply other threads:[~2015-03-02 11:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-06 16:30 [PATCH] pinctrl: imx: do not implicitly set pin regs to -1 Stefan Agner
2015-02-06 19:21 ` Uwe Kleine-König
2015-02-06 19:40 ` Stefan Agner
2015-03-02 11:45 ` Shawn Guo [this message]
2015-03-02 12:59 ` Uwe Kleine-König
2015-03-02 13:42 ` Stefan Agner
2015-03-02 15:53 ` Uwe Kleine-König
2015-03-04 23:23 ` Stefan Agner
2015-03-09 16:18 ` Linus Walleij
2015-03-09 16:18 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150302114516.GC3040@dragon \
--to=shawn.guo@linaro.org \
--cc=kernel@pengutronix.de \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stefan@agner.ch \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).