From: Ludovic Desroches <ludovic.desroches@atmel.com>
To: Baruch Siach <baruch@tkos.co.il>
Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
linux-gpio@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] pinctrl: at91: simplify probe error handling
Date: Wed, 4 Mar 2015 14:32:45 +0100 [thread overview]
Message-ID: <20150304133245.GF9132@odux.rfo.atmel.com> (raw)
In-Reply-To: <2adab2d9a86d0e44051541052ace08527bdcc045.1425317325.git.baruch@tkos.co.il>
On Mon, Mar 02, 2015 at 07:28:45PM +0200, Baruch Siach wrote:
> There is no code ender the 'err' label. Just return the error code directly.
>
Probably a remainder of pre managed resources time.
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
Acked-by: Ludovic Desroches <ludovic.desroches@atmel.com>
> ---
> drivers/pinctrl/pinctrl-at91.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/pinctrl/pinctrl-at91.c b/drivers/pinctrl/pinctrl-at91.c
> index f4cd0b9b2438..6cfe534ab27e 100644
> --- a/drivers/pinctrl/pinctrl-at91.c
> +++ b/drivers/pinctrl/pinctrl-at91.c
> @@ -1240,8 +1240,7 @@ static int at91_pinctrl_probe(struct platform_device *pdev)
>
> if (!info->pctl) {
> dev_err(&pdev->dev, "could not register AT91 pinctrl driver\n");
> - ret = -EINVAL;
> - goto err;
> + return -EINVAL;
> }
>
> /* We will handle a range of GPIO pins */
> @@ -1252,9 +1251,6 @@ static int at91_pinctrl_probe(struct platform_device *pdev)
> dev_info(&pdev->dev, "initialized AT91 pinctrl driver\n");
>
> return 0;
> -
> -err:
> - return ret;
> }
>
> static int at91_pinctrl_remove(struct platform_device *pdev)
> --
> 2.1.4
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2015-03-04 13:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-02 17:28 [PATCH] pinctrl: at91: simplify probe error handling Baruch Siach
2015-03-03 9:08 ` Alexandre Belloni
2015-03-04 13:32 ` Ludovic Desroches [this message]
2015-03-09 16:05 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150304133245.GF9132@odux.rfo.atmel.com \
--to=ludovic.desroches@atmel.com \
--cc=baruch@tkos.co.il \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).