From: Baruch Siach <baruch@tkos.co.il>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH] pinctrl: dt-binding: fix generic pinmux/pinconf examples
Date: Wed, 18 Mar 2015 14:25:17 +0200 [thread overview]
Message-ID: <20150318122517.GE7221@tarshish> (raw)
In-Reply-To: <CACRpkdbwPyuthWPswEY_BX5N=nFAgA+0A-tnW=dFT2zRC0XR6A@mail.gmail.com>
Hi Linus,
On Wed, Mar 18, 2015 at 01:16:00PM +0100, Linus Walleij wrote:
> On Sun, Mar 15, 2015 at 7:55 AM, Baruch Siach <baruch@tkos.co.il> wrote:
> > pinconf_generic_dt_node_to_map() scans only subnodes of the pinctrl-0
> > pahndle, not the referenced node itself. Change the example nodes to
> > match.
> >
> > Signed-off-by: Baruch Siach <baruch@tkos.co.il>
>
> Patch applied...
>
> > state_0_node_a {
> > - function = "uart0";
> > - groups = "u0rxtx", "u0rtscts";
> > + uart0 {
> > + function = "uart0";
> > + groups = "u0rxtx", "u0rtscts";
> > + };
> > };
> > state_1_node_a {
> > - function = "spi0";
> > - groups = "spi0pins";
> > + spi0 {
> > + function = "spi0";
> > + groups = "spi0pins";
> > + };
> > };
>
> But that is a bit insane. We should fix the parsing code to handle
> either case instead.
OK. I'll take a look into this tomorrow.
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
prev parent reply other threads:[~2015-03-18 12:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-15 6:55 [PATCH] pinctrl: dt-binding: fix generic pinmux/pinconf examples Baruch Siach
2015-03-18 12:16 ` Linus Walleij
2015-03-18 12:25 ` Baruch Siach [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150318122517.GE7221@tarshish \
--to=baruch@tkos.co.il \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).