From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sascha Hauer Subject: Re: [PATCH v4 09/11] ARM: imx: add imx7d clk tree support Date: Tue, 21 Apr 2015 16:27:47 +0200 Message-ID: <20150421142747.GD6325@pengutronix.de> References: <1429563933-3129-1-git-send-email-Frank.Li@freescale.com> <1429563933-3129-10-git-send-email-Frank.Li@freescale.com> <20150421102255.GW6325@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from metis.ext.pengutronix.de ([92.198.50.35]:58848 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755303AbbDUO1y (ORCPT ); Tue, 21 Apr 2015 10:27:54 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Zhi Li Cc: "Frank.Li@freescale.com" , Shawn Guo , Linus Walleij , robh+dt@kernel.org, "linux-arm-kernel@lists.infradead.org" , linux-gpio@vger.kernel.org, "devicetree@vger.kernel.org" , Anson Huang , Adrian Alonso On Tue, Apr 21, 2015 at 09:15:36AM -0500, Zhi Li wrote: > On Tue, Apr 21, 2015 at 5:22 AM, Sascha Hauer wrote: > > On Tue, Apr 21, 2015 at 05:05:31AM +0800, Frank.Li@freescale.com wrote: > >> From: Frank Li > >> > >> Add i.MX7D clk tree support. > >> > >> + > >> + clk_register_clkdev(clks[IMX7D_GPT1_ROOT_CLK], "ipg", "imx-gpt.0"); > >> + clk_register_clkdev(clks[IMX7D_GPT_3M_CLK], "gpt_3m", "imx-gpt.0"); > > This patch just list all clock root in RM. Maybe, still the two lines above are unused. The timer code only does a of_clk_get_by_name which will never return the clocks you register above. > all clock refine have to wait for Dong Aisheng's RFC clock framework > change's patch. > > > > > What are these good for? These shouldn't be here. > > > >> + > >> + for (i = 0; i < IMX7D_END_CLK; i++) > >> + clk_prepare_enable(clks[i]); > > > > Hey, no. You enable *all* clocks here which is certainly wrong. They > > will never be turned off. > > Yes. This patches's purpose is bring up mx7. > Because imx7 clock design change, Dong Aisheng send out RFC patch to > change a little bit framework. > After that, we can enable only necessary clock here. Otherwise system > will halt and block the other part > upstream. If that's the case you should state that in the commit message, add a comment to the code that it needs fixing once Dongs patch is in and provide a reference to the patch you need. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |