linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mark Rutland <mark.rutland@arm.com>
To: Zhi Li <lznuaa@gmail.com>
Cc: "Frank.Li@freescale.com" <Frank.Li@freescale.com>,
	"shawn.guo@linaro.org" <shawn.guo@linaro.org>,
	"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Anson Huang <b20788@freescale.com>
Subject: Re: [PATCH v5 05/11] ARM: dts: add imx7d soc dtsi file
Date: Wed, 22 Apr 2015 10:12:32 +0100	[thread overview]
Message-ID: <20150422091231.GA27345@leverpostej> (raw)
In-Reply-To: <CAHrpEqRqUJ2h2dXiwR3rcugWvszKwt10axy8jGsAJAH6Quafbg@mail.gmail.com>

On Tue, Apr 21, 2015 at 08:34:45PM +0100, Zhi Li wrote:
> >>> +
> >>> +       clocks {
> >>> +               #address-cells = <1>;
> >>> +               #size-cells = <0>;
> >>> +
> >>> +               ckil: clock@0 {
> >>> +                       compatible = "fixed-clock";
> >>> +                       reg = <0>;
> >>> +                       #clock-cells = <0>;
> >>> +                       clock-frequency = <32768>;
> >>> +                       clock-output-names = "ckil";
> >>> +               };
> >>> +
> >>> +               osc: clock@1 {
> >>> +                       compatible = "fixed-clock";
> >>> +                       reg = <1>;
> >>> +                       #clock-cells = <0>;
> >>> +                       clock-frequency = <24000000>;
> >>> +                       clock-output-names = "osc";
> >>> +               };
> >>> +
> >>> +       };
> >>
> >> Get rid of the clocks container node, and put these under the root.
> >
> > Okay.
> 
> After remove clocks node.
> There will be warning
> 
> Warning (reg_format): "reg" property in /clock@0 has invalid length (4
> bytes) (#address-cells == 1, #size-cells == 1)
> Warning (reg_format): "reg" property in /clock@1 has invalid length (4
> bytes) (#address-cells == 1, #size-cells == 1)

The reg property is meainingless, so just remove it and give the clocks
different names.

Mark.

  reply	other threads:[~2015-04-22  9:12 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-21 14:53 [PATCH v5 00/11] Add Freescale i.mx7d support Frank.Li
2015-04-21 14:53 ` [PATCH v5 01/11] ARM: dts: add pinfunc include file to support imx7d Frank.Li
2015-04-21 14:53 ` [PATCH v5 02/11] ARM: dts: add pinfunc include file gpio1 " Frank.Li
2015-04-21 14:53 ` [PATCH v5 03/11] ARM: dts: add clock include file " Frank.Li
     [not found] ` <1429628007-8892-1-git-send-email-Frank.Li-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2015-04-21 14:53   ` [PATCH v5 04/11] Document: dt: binding: imx: update document for imx7d support Frank.Li-KZfg59tc24xl57MIdRCFDg
2015-04-21 14:53 ` [PATCH v5 05/11] ARM: dts: add imx7d soc dtsi file Frank.Li
2015-04-21 17:28   ` Mark Rutland
2015-04-21 18:48     ` Zhi Li
2015-04-21 19:34       ` Zhi Li
2015-04-22  9:12         ` Mark Rutland [this message]
2015-04-22 14:08           ` Zhi Li
2015-04-21 14:53 ` [PATCH v5 06/11] pinctrl: add imx7d support Frank.Li
2015-04-21 14:53 ` [PATCH v5 07/11] ARM: imx: add msl support for imx7d Frank.Li
2015-04-21 15:12   ` Russell King - ARM Linux
     [not found]     ` <20150421151225.GZ12732-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2015-04-21 15:19       ` Zhi Li
2015-04-21 17:31   ` Mark Rutland
2015-04-21 18:51     ` Zhi Li
     [not found]       ` <CAHrpEqRAEMammfaovi6QQxGJfW-LZsgwg5rX4-3Y=+m6qhqeTg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-04-21 20:22         ` Rob Herring
2015-04-21 20:37           ` Zhi Li
2015-04-21 14:53 ` [PATCH v5 08/11] ARM: imx: add gpt system timer " Frank.Li
     [not found]   ` <1429628007-8892-9-git-send-email-Frank.Li-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2015-04-21 20:25     ` Rob Herring
2015-04-21 14:53 ` [PATCH v5 09/11] ARM: imx: add imx7d clk tree support Frank.Li
2015-04-21 20:30   ` Rob Herring
2015-04-21 20:39     ` Zhi Li
2015-04-21 20:47       ` Rob Herring
2015-04-21 20:51         ` Zhi Li
2015-04-24  8:28           ` Shawn Guo
2015-04-21 14:53 ` [PATCH v5 10/11] arm: dts: add imx7d-sdb support Frank.Li
2015-04-21 14:53 ` [PATCH v5 11/11] ARM: config: imx_v6_v7_defconfig add imx7d support Frank.Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150422091231.GA27345@leverpostej \
    --to=mark.rutland@arm.com \
    --cc=Frank.Li@freescale.com \
    --cc=b20788@freescale.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=lznuaa@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=shawn.guo@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).