From: Richard Fitzgerald <rf@opensource.wolfsonmicro.com>
To: Mark Brown <broonie@kernel.org>
Cc: lee.jones@linaro.org, linus.walleij@linaro.org, gnurou@gmail.com,
myungjoo.ham@samsung.com, cw00.choi@samsung.com,
ckeepax@opensource.wolfsonmicro.com,
patches@opensource.wolfsonmicro.com,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 3/8] mfd: arizona: Add support for WM8998 and WM1814
Date: Mon, 27 Apr 2015 13:40:19 +0100 [thread overview]
Message-ID: <20150427124019.GA3622@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20150422110808.GU22845@sirena.org.uk>
On Wed, Apr 22, 2015 at 12:08:08PM +0100, Mark Brown wrote:
> On Tue, Apr 21, 2015 at 01:33:51PM +0100, Richard Fitzgerald wrote:
>
> > + switch (arizona->type) {
> > + case WM8998:
> > + case WM1814:
> > + /* Some bits are shifted on WM8998,
> > + * rearrange to match the standard bit layout
> > + */
> > + val[0] = ((val[0] & 0x60e0) >> 1) |
> > + ((val[0] & 0x1e00) >> 2) |
> > + (val[0] & 0x000f);
> > + break;
>
> Are you sure this approach is going to scale (and avoid confusion)?
It's a total one-off for the WM8998/WM1814, no other codecs have
this shifted-bit-position problem. This shouldn't happen for any
future codecs, so I don't feel like it's worth over-complicating it.
next prev parent reply other threads:[~2015-04-27 12:40 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-21 12:33 [PATCH 0/8] Add support for Wolfson WM8998 and WM1814 codecs Richard Fitzgerald
2015-04-21 12:33 ` [PATCH 1/8] mfd: arizona: Split INx_MODE into two fields Richard Fitzgerald
2015-04-21 12:33 ` [PATCH 2/8] ASoC: arizona: add defines for single-input gain control Richard Fitzgerald
2015-04-22 11:05 ` Mark Brown
2015-04-21 12:33 ` [PATCH 3/8] mfd: arizona: Add support for WM8998 and WM1814 Richard Fitzgerald
[not found] ` <1429619636-25478-4-git-send-email-rf-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2015-04-22 11:08 ` Mark Brown
2015-04-27 12:40 ` Richard Fitzgerald [this message]
2015-04-21 12:33 ` [PATCH 4/8] gpio: arizona: add " Richard Fitzgerald
2015-04-28 12:59 ` Linus Walleij
2015-04-21 12:33 ` [PATCH 5/8] regulator: " Richard Fitzgerald
2015-04-22 11:04 ` Mark Brown
2015-04-21 12:33 ` [PATCH 6/8] extcon: arizona: Add " Richard Fitzgerald
2015-04-22 5:53 ` Chanwoo Choi
2015-04-22 9:19 ` Richard Fitzgerald
2015-04-22 10:20 ` Chanwoo Choi
2015-04-23 14:15 ` Richard Fitzgerald
2015-04-24 0:59 ` [alsa-devel] " Chanwoo Choi
2015-04-21 12:33 ` [PATCH 7/8] ASoC: wm8998: Initial WM8998 codec driver Richard Fitzgerald
2015-04-22 11:00 ` Mark Brown
[not found] ` <20150422110030.GQ22845-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-04-23 14:28 ` Richard Fitzgerald
2015-04-23 17:54 ` Mark Brown
2015-04-22 19:46 ` Paul Bolle
2015-04-21 12:33 ` [PATCH 8/8] Documentation: Add WM8998/WM1814 device tree bindings Richard Fitzgerald
2015-04-23 2:05 ` Austin, Brian
2015-04-23 14:46 ` [alsa-devel] " Richard Fitzgerald
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150427124019.GA3622@opensource.wolfsonmicro.com \
--to=rf@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=gnurou@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).