* [PATCH 2/2] gpio: x-gene: Remove a useless memset
@ 2015-05-01 12:29 Christophe Jaillet
2015-05-01 14:19 ` Dan Carpenter
2015-05-12 7:43 ` Linus Walleij
0 siblings, 2 replies; 5+ messages in thread
From: Christophe Jaillet @ 2015-05-01 12:29 UTC (permalink / raw)
To: linus.walleij, gnurou
Cc: linux-gpio, linux-kernel, kernel-janitors, Christophe Jaillet
priv->irq is allocated using devm_kzalloc so there is no need to memset it.
Signed-off-by: Christophe Jaillet <christophe.jaillet@wanadoo.fr>
---
drivers/gpio/gpio-xgene-sb.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpio/gpio-xgene-sb.c b/drivers/gpio/gpio-xgene-sb.c
index fb9d29a..a7b8f8f 100644
--- a/drivers/gpio/gpio-xgene-sb.c
+++ b/drivers/gpio/gpio-xgene-sb.c
@@ -112,7 +112,6 @@ static int xgene_gpio_sb_probe(struct platform_device *pdev)
GFP_KERNEL);
if (!priv->irq)
return -ENOMEM;
- memset(priv->irq, 0, sizeof(u32) * XGENE_MAX_GPIO_DS);
for (i = 0; i < priv->nirq; i++) {
priv->irq[default_lines[i]] = platform_get_irq(pdev, i);
--
2.1.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH 2/2] gpio: x-gene: Remove a useless memset
2015-05-01 12:29 [PATCH 2/2] gpio: x-gene: Remove a useless memset Christophe Jaillet
@ 2015-05-01 14:19 ` Dan Carpenter
2015-05-01 14:54 ` Marion & Christophe JAILLET
2015-05-12 7:43 ` Linus Walleij
1 sibling, 1 reply; 5+ messages in thread
From: Dan Carpenter @ 2015-05-01 14:19 UTC (permalink / raw)
To: Christophe Jaillet
Cc: linus.walleij, gnurou, linux-gpio, linux-kernel, kernel-janitors
The "[PATCH 2/2]" bit is a mistake. It's not part of a patchset. It's
just that you have sent two patches today. The first patch wasn't even
named [1/2]...
Unless, it is part of a patchset?? If so where is the first patch?
regards,
dan carpenter
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] gpio: x-gene: Remove a useless memset
2015-05-01 14:19 ` Dan Carpenter
@ 2015-05-01 14:54 ` Marion & Christophe JAILLET
2015-05-01 15:44 ` Dan Carpenter
0 siblings, 1 reply; 5+ messages in thread
From: Marion & Christophe JAILLET @ 2015-05-01 14:54 UTC (permalink / raw)
To: Dan Carpenter
Cc: linus.walleij, gnurou, linux-gpio, linux-kernel, kernel-janitors
Hi,
yes, you are correct, it's a mistake.
Should I resubmit with an updated subject?
CJ
Le 01/05/2015 16:19, Dan Carpenter a écrit :
> The "[PATCH 2/2]" bit is a mistake. It's not part of a patchset. It's
> just that you have sent two patches today. The first patch wasn't even
> named [1/2]...
>
> Unless, it is part of a patchset?? If so where is the first patch?
>
> regards,
> dan carpenter
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] gpio: x-gene: Remove a useless memset
2015-05-01 14:54 ` Marion & Christophe JAILLET
@ 2015-05-01 15:44 ` Dan Carpenter
0 siblings, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2015-05-01 15:44 UTC (permalink / raw)
To: Marion & Christophe JAILLET
Cc: linus.walleij, gnurou, linux-gpio, linux-kernel, kernel-janitors
On Fri, May 01, 2015 at 04:54:28PM +0200, Marion & Christophe JAILLET wrote:
> Hi,
>
> yes, you are correct, it's a mistake.
> Should I resubmit with an updated subject?
No.
Also don't top post etc etc.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] gpio: x-gene: Remove a useless memset
2015-05-01 12:29 [PATCH 2/2] gpio: x-gene: Remove a useless memset Christophe Jaillet
2015-05-01 14:19 ` Dan Carpenter
@ 2015-05-12 7:43 ` Linus Walleij
1 sibling, 0 replies; 5+ messages in thread
From: Linus Walleij @ 2015-05-12 7:43 UTC (permalink / raw)
To: Christophe Jaillet
Cc: Alexandre Courbot, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors
On Fri, May 1, 2015 at 2:29 PM, Christophe Jaillet
<christophe.jaillet@wanadoo.fr> wrote:
> priv->irq is allocated using devm_kzalloc so there is no need to memset it.
>
> Signed-off-by: Christophe Jaillet <christophe.jaillet@wanadoo.fr>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-05-12 7:43 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-01 12:29 [PATCH 2/2] gpio: x-gene: Remove a useless memset Christophe Jaillet
2015-05-01 14:19 ` Dan Carpenter
2015-05-01 14:54 ` Marion & Christophe JAILLET
2015-05-01 15:44 ` Dan Carpenter
2015-05-12 7:43 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).