linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: Joshua Scott <joshua.scott@alliedtelesis.co.nz>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	Alexandre Courbot <gnurou@gmail.com>,
	Patrice Chotard <patrice.chotard@st.com>,
	Fabian Frederick <fabf@skynet.be>,
	Wolfram Sang <wsa@the-dreams.de>,
	linux-gpio@vger.kernel.org,
	Chris Packham <chris.packham@alliedtelesis.co.nz>
Subject: Re: [PATCH] gpio: pinctrl: Initialize Armada-XP GPIO/Pinctrl drivers at arch_initcall
Date: Tue, 12 May 2015 09:18:15 +0200	[thread overview]
Message-ID: <20150512091815.62249e70@free-electrons.com> (raw)
In-Reply-To: <1431398382-1894-1-git-send-email-joshua.scott@alliedtelesis.co.nz>

Dear Joshua Scott,

On Tue, 12 May 2015 14:39:42 +1200, Joshua Scott wrote:
> The Armada-XP contains a set of GPIO pins. These pins may be used to take
> other hardware out of reset. However, the drivers used are currently not
> initialized until quite late in the boot process (module_platform_driver).
> 
> This patch replaces the use of module_platform_driver with arch_initcall
> in the two drivers that are used to control the GPIO pins. This allows for
> drivers using subsys_initcall or later to access to the pins.
> 
> 
> Signed-off-by: Joshua Scott <joshua.scott@alliedtelesis.co.nz>

Thanks for the patch. However, this goes exactly in the opposite
direction of commit dd640039e8de4135fd59d4d963487d1239d6fabe ("gpio:
mvebu: Remove initcall-based driver initialization"), which switched
from postcore_initcall() to module_platform_driver().

Can you describe which drivers registered at subsys_initcall() need
those GPIOs? We should be able to get around by using deferred probing.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2015-05-12  7:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-12  2:39 [PATCH] gpio: pinctrl: Initialize Armada-XP GPIO/Pinctrl drivers at arch_initcall Joshua Scott
2015-05-12  7:18 ` Thomas Petazzoni [this message]
2015-05-12 22:29   ` Joshua Scott
2015-05-13  7:42     ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150512091815.62249e70@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=chris.packham@alliedtelesis.co.nz \
    --cc=fabf@skynet.be \
    --cc=gnurou@gmail.com \
    --cc=joshua.scott@alliedtelesis.co.nz \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=patrice.chotard@st.com \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).