From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [PATCH v3 01/17] mfd: add new driver for Sharp LoCoMo Date: Tue, 19 May 2015 12:21:34 +0100 Message-ID: <20150519112134.GD2067@n2100.arm.linux.org.uk> References: <1431880077-26321-1-git-send-email-dbaryshkov@gmail.com> <1431880077-26321-2-git-send-email-dbaryshkov@gmail.com> <20150519103828.GU22418@x1> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20150519103828.GU22418@x1> Sender: linux-spi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Lee Jones Cc: Dmitry Eremin-Solenikov , Daniel Mack , Robert Jarzmik , Linus Walleij , Alexandre Courbot , Wolfram Sang , Dmitry Torokhov , Bryan Wu , Richard Purdie , Samuel Ortiz , Mark Brown , Jingoo Han , Jean-Christophe Plagniol-Villard , Tomi Valkeinen , Liam Girdwood , Andrea Adami , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-leds-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org List-Id: linux-gpio@vger.kernel.org On Tue, May 19, 2015 at 11:38:28AM +0100, Lee Jones wrote: > On Sun, 17 May 2015, Dmitry Eremin-Solenikov wrote: > > +static void locomo_mask_irq(struct irq_data *d) > > +{ > > + struct locomo *ldev = irq_data_get_irq_chip_data(d); > > + unsigned int mask = 0x0010 << d->hwirq; > > This also needs defining. > > Why not > BIT(d->hwirq + 1) I think your maths is off... 0x0010 << d->hwirq != BIT(d->hwirq + 1) -- FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up according to speedtest.net. -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html