From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Vladimir Zapolskiy <vz@mleia.com>
Cc: Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <acourbot@nvidia.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>,
linux-gpio@vger.kernel.org, alsa-devel@alsa-project.org,
Lars-Peter Clausen <lars@metafoo.de>,
Axel Lin <axel.lin@ingics.com>,
patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH 3/7] ASoC: wm8903: generalize GPIO control register bits
Date: Tue, 2 Jun 2015 10:19:43 +0100 [thread overview]
Message-ID: <20150602091943.GE3449@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1433200158-6890-3-git-send-email-vz@mleia.com>
On Tue, Jun 02, 2015 at 02:09:14AM +0300, Vladimir Zapolskiy wrote:
> All GPIO1/2/3/4/5 control registers have the same bit map, but in
> implementation of gpiolib callbacks WM8903_GPn_*, WM8903_GP1_* and
> WM8903_GP2_* macro are mixed up. Replace particular GPIOn control
> register bit definitions with generic ones and save ~150 LoCs.
>
> No functional change.
>
> Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
> Cc: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
> Cc: Lars-Peter Clausen <lars@metafoo.de>
> Cc: Axel Lin <axel.lin@ingics.com>
> Cc: patches@opensource.wolfsonmicro.com
> ---
If Mark's ok with this I think I am. Generally those register
files tend to list all the bits on the chip, but certainly in
this case nothing is really added by listing all the GPIO
registers seperately.
Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Thanks,
Charles
next prev parent reply other threads:[~2015-06-02 9:19 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-01 23:07 [PATCH 0/7] ASoC: remove bitwise operations on GPIO level value Vladimir Zapolskiy
2015-06-01 23:09 ` [PATCH 1/7] ASoC: rt5677: add GPIO helper macros Vladimir Zapolskiy
2015-06-02 5:23 ` Takashi Iwai
2015-06-01 23:09 ` [PATCH 2/7] ASoC: rt5677: clean up gpiolib callbacks Vladimir Zapolskiy
2015-06-02 19:38 ` Mark Brown
2015-06-02 20:39 ` Vladimir Zapolskiy
2015-06-02 20:50 ` Mark Brown
2015-06-02 21:54 ` Vladimir Zapolskiy
2015-06-03 11:38 ` Mark Brown
2015-06-01 23:09 ` [PATCH 3/7] ASoC: wm8903: generalize GPIO control register bits Vladimir Zapolskiy
2015-06-02 9:19 ` Charles Keepax [this message]
2015-06-04 8:30 ` Linus Walleij
2015-06-04 8:47 ` [alsa-devel] " Charles Keepax
2015-06-04 9:19 ` Mark Brown
2015-06-04 9:24 ` Charles Keepax
2015-06-04 10:34 ` Mark Brown
2015-06-01 23:09 ` [PATCH 4/7] ASoC: wm8903: simplify gpiolib callbacks Vladimir Zapolskiy
2015-06-02 8:38 ` Charles Keepax
2015-06-02 19:41 ` Mark Brown
2015-06-02 20:18 ` Vladimir Zapolskiy
2015-06-02 20:31 ` Mark Brown
2015-06-02 20:41 ` Vladimir Zapolskiy
2015-06-01 23:09 ` [PATCH 5/7] ASoC: wm5100: remove bitwise operations involving GPIO level value Vladimir Zapolskiy
2015-06-02 8:40 ` Charles Keepax
2015-06-02 19:45 ` Mark Brown
2015-06-02 20:23 ` Vladimir Zapolskiy
2015-06-02 20:36 ` Mark Brown
2015-06-02 20:58 ` Vladimir Zapolskiy
2015-06-03 10:50 ` Trent Piepho
2015-06-03 11:07 ` Mark Brown
2015-06-03 19:13 ` [alsa-devel] " Vladimir Zapolskiy
2015-06-03 21:51 ` Trent Piepho
2015-06-03 22:58 ` Vladimir Zapolskiy
2015-06-01 23:09 ` [PATCH 6/7] ASoC: wm8962: " Vladimir Zapolskiy
2015-06-02 8:41 ` Charles Keepax
2015-06-01 23:09 ` [PATCH 7/7] ASoC: wm8996: " Vladimir Zapolskiy
2015-06-02 8:43 ` Charles Keepax
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150602091943.GE3449@opensource.wolfsonmicro.com \
--to=ckeepax@opensource.wolfsonmicro.com \
--cc=acourbot@nvidia.com \
--cc=alsa-devel@alsa-project.org \
--cc=axel.lin@ingics.com \
--cc=broonie@kernel.org \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).